[heap] pause observers during mark-compact

src/heap/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/heap.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/base/bits.h"
 #include "src/base/once.h"
@@ skipping 1367 matching lines @@
       }
     }
   }
 }
 
 
 void Heap::MarkCompact() {
   gc_state_ = MARK_COMPACT;
   LOG(isolate_, ResourceEvent("markcompact", "begin"));
 
+  new_space()->PauseInlineAllocationObservers();

[Hannes Payer (out of office), 2015/11/26 09:55:10]

A scope would be cleaner for pausing and resuming. WDYT?

[ofrobots, 2015/12/02 06:05:31]

Done.

+
   uint64_t size_of_objects_before_gc = SizeOfObjects();
 
   mark_compact_collector()->Prepare();
 
   ms_count_++;
 
   MarkCompactPrologue();
 
   mark_compact_collector()->CollectGarbage();
 
   LOG(isolate_, ResourceEvent("markcompact", "end"));
 
   MarkCompactEpilogue();
 
   if (FLAG_allocation_site_pretenuring) {
     EvaluateOldSpaceLocalPretenuring(size_of_objects_before_gc);
   }
+
+  new_space()->ResumeInlineAllocationObservers();
 }
 
 
 void Heap::MarkCompactEpilogue() {
   gc_state_ = NOT_IN_GC;
 
   isolate_->counters()->objs_since_last_full()->Set(0);
 
   incremental_marking()->Epilogue();
 
@@ skipping 4755 matching lines @@
 }
 
 
 // static
 int Heap::GetStaticVisitorIdForMap(Map* map) {
   return StaticVisitorBase::GetVisitorId(map);
 }
 
 }  // namespace internal
 }  // namespace v8