Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1465213002: Subzero. ARM32. Combine allocas. (Closed)

Created:
5 years ago by John
Modified:
5 years ago
Reviewers:
sehr, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adds helpers to prevent creating unbound temporaries after regalloc. #

Patch Set 3 : Fixes lit tests, fixes -Om1 (broken by another CL), and make format. #

Patch Set 4 : Addresses necro-comments. #

Total comments: 4

Patch Set 5 : Addresses comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -92 lines) Patch
M src/IceCfg.cpp View 1 2 3 4 1 chunk +8 lines, -2 lines 0 comments Download
M src/IceTargetLowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 2 3 4 5 chunks +35 lines, -9 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 31 chunks +131 lines, -40 lines 0 comments Download
M tests_lit/assembler/arm32/bic.ll View 1 2 1 chunk +24 lines, -29 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 2 5 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
John
5 years ago (2015-11-23 19:01:18 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1465213002/diff/60001/src/IceCfg.cpp File src/IceCfg.cpp (right): https://codereview.chromium.org/1465213002/diff/60001/src/IceCfg.cpp#newcode487 src/IceCfg.cpp:487: // upwards from the stack pointer. Besides, if ...
5 years ago (2015-11-23 19:36:20 UTC) #3
John
https://codereview.chromium.org/1465213002/diff/60001/src/IceCfg.cpp File src/IceCfg.cpp (right): https://codereview.chromium.org/1465213002/diff/60001/src/IceCfg.cpp#newcode487 src/IceCfg.cpp:487: // upwards from the stack pointer. Besides, if the ...
5 years ago (2015-11-23 19:42:36 UTC) #4
John
5 years ago (2015-11-23 19:43:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
614140e2be672234e28e3179eba9f973eb6a19c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698