Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 1465153004: [css-grid] Avoid duplicated calls to resolution code (Closed)

5 years, 1 month ago by Manuel Rego
5 years ago
chromium-reviews, jfernandez,, zoltan1, svillar,,, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
Target Ref:


[css-grid] Avoid duplicated calls to resolution code We were calling GridResolvedPosition::resolveGridPositionsFromStyle() several times per item. We can store the GridCoordinates in LayoutGrid::populateExplicitGridAndOrderIterator() and reuse them in the placement code. Once LayoutGrid::placeItemsOnGrid() is over, all the items will have a definite position in both axis. No new tests, no change of behavior. BUG=444011 GridResolvedPosition::resolveGridPositionsFromStyle Committed: Cr-Commit-Position: refs/heads/master@{#361855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 8 chunks +24 lines, -11 lines 0 comments Download


Total messages: 9 (3 generated)
Manuel Rego
Another small patch following the plan described at
5 years, 1 month ago (2015-11-23 22:17:01 UTC) #2
LGTM, but I admit I'm not an expert on the placement logic.
5 years ago (2015-11-25 21:28:54 UTC) #3
lgtm. looks reasonable.
5 years ago (2015-11-26 01:17:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at View timeline at
5 years ago (2015-11-26 08:23:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 09:32:27 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-26 09:33:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
Cr-Commit-Position: refs/heads/master@{#361855}

Powered by Google App Engine
This is Rietveld 408576698