Issue 146503002: Revert 165189 "Rendering text-justify:distribute for 8 bit chara..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146503002: Revert 165189 "Rendering text-justify:distribute for 8 bit chara..." (Closed)

Created:
6 years, 11 months ago by inferno

Modified:
6 years, 11 months ago

Reviewers:
dw.im

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 165189 "Rendering text-justify:distribute for 8 bit chara..." Cause memory corruption bugs on ClusterFuzz. > Rendering text-justify:distribute for 8 bit characters. > > text-justify:distribute provides the ability to justify a line as inter-character level. > This patch takes care of only 8 bit characters. > > BUG=248894 > > Review URL: https://codereview.chromium.org/54743004 TBR=dw.im@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165707

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -88 lines)			Patch
M	trunk/LayoutTests/fast/css3-text/css3-text-justify/resources/text-justify.css	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	trunk/LayoutTests/fast/css3-text/css3-text-justify/text-justify-8bits.html	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	trunk/LayoutTests/platform/linux/fast/css3-text/css3-text-justify/text-justify-8bits-expected.png	View	Binary file		0 comments	Download
M	trunk/Source/core/rendering/InlineTextBox.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/Source/core/rendering/RenderBlockLineLayout.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/platform/fonts/Font.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/platform/fonts/Font.cpp	View	1 chunk	+10 lines, -13 lines	0 comments	Download
M	trunk/Source/platform/fonts/WidthIterator.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/Source/platform/fonts/WidthIterator.cpp	View	3 chunks	+5 lines, -8 lines	0 comments	Download
M	trunk/Source/platform/fonts/mac/ComplexTextController.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/Source/platform/fonts/mac/ComplexTextController.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	trunk/Source/platform/text/TextRun.h	View	6 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/Source/platform/text/TextRun.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r165707.