Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 54743004: Rendering text-justify:distribute for 8 bit characters. (Closed)

Created:
7 years, 1 month ago by dw.im
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, danakj, Rik, jchaffraix+rendering, Stephen Chennney, pdr., donggwan.kim_samsung.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rendering text-justify:distribute for 8 bit characters. text-justify:distribute provides the ability to justify a line as inter-character level. This patch takes care of only 8 bit characters. BUG=248894 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165189

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Total comments: 6

Patch Set 3 : removing default value of distributeJustification #

Patch Set 4 : #

Patch Set 5 : Fix windows build error, some layouttest failures #

Patch Set 6 : #

Patch Set 7 : Fix build error #

Patch Set 8 : Add the test case in the TestExpectaions as NeedsRebaseline #

Total comments: 1

Patch Set 9 : Patch for landing #

Patch Set 10 : new patchset #

Patch Set 11 : use const parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -167 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-justify/resources/text-justify.css View 1 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/css3-text/css3-text-justify/text-justify-8bits.html View 1 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/css3-text/css3-text-justify/text-justify-8bits-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/linux/fast/css3-text/css3-text-justify/text-justify-8bits-expected.txt View 1 2 3 4 5 6 7 8 9 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/mac/fast/css3-text/css3-text-justify/text-justify-8bits-expected.png View 1 2 3 4 5 6 7 8 9 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/css3-text/css3-text-justify/text-justify-8bits-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/platform/win/fast/css3-text/css3-text-justify/text-justify-8bits-expected.png View 1 2 3 4 5 6 7 8 9 Binary file 0 comments Download
D LayoutTests/platform/win/fast/css3-text/css3-text-justify/text-justify-8bits-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -72 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/Character.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/Character.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +12 lines, -12 lines 0 comments Download
M Source/platform/fonts/WidthIterator.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/WidthIterator.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -5 lines 0 comments Download
M Source/platform/fonts/mac/ComplexTextController.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/mac/ComplexTextController.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -2 lines 0 comments Download
M Source/platform/text/TextRun.h View 1 2 3 4 5 6 7 8 9 6 chunks +7 lines, -0 lines 0 comments Download
M Source/platform/text/TextRun.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
dw.im
7 years, 1 month ago (2013-11-01 05:25:26 UTC) #1
dw.im
I wanted to use reference test, but I don't know how I can make the ...
7 years, 1 month ago (2013-11-01 06:45:40 UTC) #2
leviw_travelin_and_unemployed
I don't think you can do this test as a ref test. https://codereview.chromium.org/54743004/diff/1/Source/core/platform/graphics/Font.h File Source/core/platform/graphics/Font.h ...
7 years, 1 month ago (2013-11-01 20:39:13 UTC) #3
dw.im
https://codereview.chromium.org/54743004/diff/1/Source/core/platform/graphics/Font.h File Source/core/platform/graphics/Font.h (right): https://codereview.chromium.org/54743004/diff/1/Source/core/platform/graphics/Font.h#newcode159 Source/core/platform/graphics/Font.h:159: static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion, ...
7 years, 1 month ago (2013-11-02 03:13:01 UTC) #4
dw.im
I've uploaded a new patchset for review. https://codereview.chromium.org/54743004/diff/1/Source/core/platform/graphics/Font.h File Source/core/platform/graphics/Font.h (right): https://codereview.chromium.org/54743004/diff/1/Source/core/platform/graphics/Font.h#newcode159 Source/core/platform/graphics/Font.h:159: static unsigned ...
7 years, 1 month ago (2013-11-04 02:11:08 UTC) #5
leviw_travelin_and_unemployed
https://codereview.chromium.org/54743004/diff/110001/Source/core/platform/graphics/Font.h File Source/core/platform/graphics/Font.h (right): https://codereview.chromium.org/54743004/diff/110001/Source/core/platform/graphics/Font.h#newcode160 Source/core/platform/graphics/Font.h:160: static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion, ...
7 years, 1 month ago (2013-11-04 19:37:58 UTC) #6
dw.im
https://codereview.chromium.org/54743004/diff/110001/Source/core/platform/graphics/Font.h File Source/core/platform/graphics/Font.h (right): https://codereview.chromium.org/54743004/diff/110001/Source/core/platform/graphics/Font.h#newcode160 Source/core/platform/graphics/Font.h:160: static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion, ...
7 years, 1 month ago (2013-11-05 10:26:05 UTC) #7
leviw_travelin_and_unemployed
https://codereview.chromium.org/54743004/diff/110001/Source/core/platform/graphics/Font.h File Source/core/platform/graphics/Font.h (right): https://codereview.chromium.org/54743004/diff/110001/Source/core/platform/graphics/Font.h#newcode160 Source/core/platform/graphics/Font.h:160: static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion, ...
7 years, 1 month ago (2013-11-05 19:07:24 UTC) #8
dw.im
Dear Levi, Please check the new patchset. Thanks!!
6 years, 11 months ago (2014-01-03 05:56:48 UTC) #9
leviw_travelin_and_unemployed
On 2014/01/03 05:56:48, dw.im wrote: > Dear Levi, > Please check the new patchset. > ...
6 years, 11 months ago (2014-01-03 19:26:36 UTC) #10
dw.im
So, last thing I need to do is, 1. Add the expectation result for mac ...
6 years, 11 months ago (2014-01-07 09:30:35 UTC) #11
leviw_travelin_and_unemployed
On 2014/01/07 09:30:35, dw.im wrote: > So, last thing I need to do is, > ...
6 years, 11 months ago (2014-01-07 18:55:06 UTC) #12
dw.im
On 2014/01/07 18:55:06, Levi wrote: > There's a NeedsRebaseline keyword in TestExpectations which ignores the ...
6 years, 11 months ago (2014-01-08 23:02:04 UTC) #13
leviw_travelin_and_unemployed
LGTM. Typo in change description: "8 bit characters" https://codereview.chromium.org/54743004/diff/470001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/54743004/diff/470001/LayoutTests/TestExpectations#newcode859 LayoutTests/TestExpectations:859: # ...
6 years, 11 months ago (2014-01-15 19:17:28 UTC) #14
dw.im
On 2014/01/15 19:17:28, Levi wrote: > LGTM. > > Typo in change description: "8 bit ...
6 years, 11 months ago (2014-01-16 02:07:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/54743004/610001
6 years, 11 months ago (2014-01-16 03:47:37 UTC) #16
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 04:02:09 UTC) #17
Message was sent while issue was closed.
Change committed as 165189

Powered by Google App Engine
This is Rietveld 408576698