Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 14650009: Allow unit tests to include or exclude test sets. (Closed)

Created:
7 years, 7 months ago by caryclark
Modified:
7 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Allow unit tests to include or exclude test sets. This modifies the command line to take test matches of the form: --match [or -m] [~][^]match[$] [~][^]match[$] ... ~ causes a matching test to always be skipped ^ requires the start of the test to match $ requires the end of the test to match ^ and $ requires an exact match If a test does not match any list entry, it is skipped unless some list entry starts with ~ Committed: https://code.google.com/p/skia/source/detail?r=8955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M tests/skia_test.cpp View 2 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
7 years, 7 months ago (2013-04-30 17:06:19 UTC) #1
bsalomon
lgtm, but maybe the help text should be updated? Line 143 in my version: DEFINE_string2(match, ...
7 years, 7 months ago (2013-04-30 17:35:31 UTC) #2
caryclark
7 years, 7 months ago (2013-05-02 13:14:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698