Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: tests/skia_test.cpp

Issue 14650009: Allow unit tests to include or exclude test sets. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/skia_test.cpp
===================================================================
--- tests/skia_test.cpp (revision 8910)
+++ tests/skia_test.cpp (working copy)
@@ -168,8 +168,42 @@
int32_t* fFailCount;
};
+/* Takes a list of the form [~][^]match[$]
+ ~ causes a matching test to always be skipped
+ ^ requires the start of the test to match
+ $ requires the end of the test to match
+ ^ and $ requires an exact match
+ If a test does not match any list entry, it is skipped unless some list entry starts with ~
+ */
static bool shouldSkip(const char* testName) {
- return !FLAGS_match.isEmpty() && !strstr(testName, FLAGS_match[0]);
+ int count = FLAGS_match.count();
+ size_t testLen = strlen(testName);
+ bool anyExclude = false;
+ for (int index = 0; index < count; ++index) {
+ const char* matchName = FLAGS_match[index];
+ size_t matchLen = strlen(matchName);
+ bool matchExclude, matchStart, matchEnd;
+ if ((matchExclude = matchName[0] == '~')) {
+ anyExclude = true;
+ matchName++;
+ matchLen--;
+ }
+ if ((matchStart = matchName[0] == '^')) {
+ matchName++;
+ matchLen--;
+ }
+ if ((matchEnd = matchName[matchLen - 1] == '$')) {
+ matchLen--;
+ }
+ if (matchStart ? (!matchEnd || matchLen == testLen)
+ && strncmp(testName, matchName, matchLen) == 0
+ : matchEnd ? matchLen <= testLen
+ && strncmp(testName + testLen - matchLen, matchName, matchLen) == 0
+ : strstr(testName, matchName) != 0) {
+ return matchExclude;
+ }
+ }
+ return !anyExclude;
}
int tool_main(int argc, char** argv);
@@ -193,7 +227,10 @@
{
SkString header("Skia UnitTests:");
if (!FLAGS_match.isEmpty()) {
- header.appendf(" --match %s", FLAGS_match[0]);
+ header.appendf(" --match");
+ for (int index = 0; index < FLAGS_match.count(); ++index) {
+ header.appendf(" %s", FLAGS_match[index]);
+ }
}
if (!gTmpDir.isEmpty()) {
header.appendf(" --tmpDir %s", gTmpDir.c_str());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698