Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1464783003: Fix build after https://codereview.chromium.org/1457033002 (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
Tom Hudson, tomhudson
CC:
chromium-reviews, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build after https://codereview.chromium.org/1457033002 ..\..\skia\ext\platform_device.cc(20,6) : error: unused function 'SetBoolMetaData' [-Werror,-Wunused-function] void SetBoolMetaData(const SkCanvas& canvas, const char* key, bool value) { ^ ..\..\skia\ext\platform_device.cc(25,6) : error: unused function 'GetBoolMetaData' [-Werror,-Wunused-function] bool GetBoolMetaData(const SkCanvas& canvas, const char* key) { ^ BUG=82385 TBR=tomhudson Committed: https://crrev.com/29623f15f93140805385e3c328339c7919e5f2e2 Cr-Commit-Position: refs/heads/master@{#360930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M skia/ext/platform_device.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
5 years, 1 month ago (2015-11-20 21:34:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464783003/1
5 years, 1 month ago (2015-11-20 21:35:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138273) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 22:17:31 UTC) #7
Nico
Committed patchset #1 (id:1) manually as 29623f15f93140805385e3c328339c7919e5f2e2 (presubmit successful).
5 years, 1 month ago (2015-11-20 22:22:42 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29623f15f93140805385e3c328339c7919e5f2e2 Cr-Commit-Position: refs/heads/master@{#360930}
5 years, 1 month ago (2015-11-20 23:03:35 UTC) #9
tomhudson
Oops, thanks. LGTM. The CQ missed it?
5 years, 1 month ago (2015-11-23 13:48:32 UTC) #10
Nico
5 years, 1 month ago (2015-11-23 14:35:03 UTC) #11
Message was sent while issue was closed.
The clang/win bots aren't on the cq yet.

On Mon, Nov 23, 2015 at 8:48 AM, <tomhudson@google.com> wrote:

> Oops, thanks.
>
> LGTM.
>
> The CQ missed it?
>
> https://codereview.chromium.org/1464783003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698