Get rid of unused skia::IsDraftMode()

Get rid of unused skia::IsDraftMode()

We had callers of SetIsDraftMode, but no code that actually queried
for that metadata. This helps us get rid of platform_device.h.

Since [Set]IsPreviewMetafile() is only used on Mac, remove ifdef
that also built those functions on Windows.

BUG=543755
R=halcanary@chromium.org,thestig@chromium.org

Committed: https://crrev.com/fa5a66979cdf91dc7c0cb79f54dda08254c343ec
Cr-Commit-Position: refs/heads/master@{#360597}

[Tom Hudson, 2015-11-18 19:16:11]

The CQ bit was checked by tomhudson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-18 19:18:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457033002/1

[Tom Hudson, 2015-11-18 20:11:00]

Looks like bots are happy; PTAL.

[Lei Zhang, 2015-11-18 20:19:36]

We never implemented draft mode. Oh well.

https://codereview.chromium.org/1457033002/diff/1/skia/ext/platform_device.cc
File skia/ext/platform_device.cc (right):

https://codereview.chromium.org/1457033002/diff/1/skia/ext/platform_device.cc...
skia/ext/platform_device.cc:14: const char* kDevicePlatformBehaviour =
"CrDevicePlatformBehaviour";
BTW, these should be const char kFoo[];

Right now someone can change what the pointer points to.

https://codereview.chromium.org/1457033002/diff/1/skia/ext/platform_device.cc...
skia/ext/platform_device.cc:15: const char* kDraftModeKey = "CrDraftMode";
Remove as well?

https://codereview.chromium.org/1457033002/diff/1/skia/ext/platform_device.cc...
skia/ext/platform_device.cc:17: #if defined(OS_MACOSX) || defined(OS_WIN)
Also Mac-only?

https://codereview.chromium.org/1457033002/diff/1/skia/ext/platform_device.h
File skia/ext/platform_device.h (right):

https://codereview.chromium.org/1457033002/diff/1/skia/ext/platform_device.h#...
skia/ext/platform_device.h:74: // Following routines are used in print preview
workflow to mark the draft mode
comment needs updating

[Lei Zhang, 2015-11-18 20:19:54]

and lgtm

[Tom Hudson, 2015-11-18 20:46:47]

Thanks for the careful reading; should all be done now.

[hal.canary, 2015-11-18 20:56:08]

halcanary@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2015-11-18 20:56:08]

lgtm

[Tom Hudson, 2015-11-19 13:24:23]

The CQ bit was checked by tomhudson@chromium.org

[Tom Hudson, 2015-11-19 13:24:24]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1457033002/#ps20001
(title: "thestig review")

[commit-bot: I haz the power, 2015-11-19 13:24:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457033002/20001

[commit-bot: I haz the power, 2015-11-19 13:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 13:44:13]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Tom Hudson, 2015-11-19 14:59:54]

The CQ bit was checked by tomhudson@chromium.org

[commit-bot: I haz the power, 2015-11-19 15:00:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457033002/20001

[commit-bot: I haz the power, 2015-11-19 16:22:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 16:23:56]

Patchset 2 (id:??) landed as
https://crrev.com/fa5a66979cdf91dc7c0cb79f54dda08254c343ec
Cr-Commit-Position: refs/heads/master@{#360597}