chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java - Issue 1464743005: Remove DocumentTabObserver and merge task description updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

Issue 1464743005: Remove DocumentTabObserver and merge task description updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment for Webapps and removed needsUpdate in observer call Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

index 3d06bf9e5974e11e3a5e060a40b6313de8e20785..3078f9ac7b8dfc76ad04cae3919db7ec4650142b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.browser.tab;

+import android.graphics.Bitmap;

import android.view.ContextMenu;

import org.chromium.content.browser.ContentViewCore;

@@ -49,7 +50,7 @@ public class EmptyTabObserver implements TabObserver {

public void onPageLoadFailed(Tab tab, int errorCode) { }

@Override

- public void onFaviconUpdated(Tab tab) { }

+ public void onFaviconUpdated(Tab tab, Bitmap icon) { }

@Override

public void onTitleUpdated(Tab tab) { }