Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java

Issue 1464743005: Remove DocumentTabObserver and merge task description updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment for Webapps and removed needsUpdate in observer call Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java
index ac4356518bba866280aba58732b76bdfc05897b9..8108442b711cab340d91f4c1cca9a8da67e16589 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java
@@ -5,9 +5,7 @@
package org.chromium.chrome.browser.document;
import android.app.Activity;
-import android.graphics.Bitmap;
-import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeApplication;
import org.chromium.chrome.browser.IntentHandler;
@@ -15,10 +13,8 @@ import org.chromium.chrome.browser.TabState;
import org.chromium.chrome.browser.WarmupManager;
import org.chromium.chrome.browser.WebContentsFactory;
import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
-import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabDelegateFactory;
-import org.chromium.chrome.browser.tab.TabObserver;
import org.chromium.chrome.browser.tab.TabUma;
import org.chromium.chrome.browser.tab.TabUma.TabCreationState;
import org.chromium.chrome.browser.tab.TabWebContentsDelegateAndroid;
@@ -32,17 +28,6 @@ import org.chromium.ui.base.WindowAndroid;
* A Tab child class with Chrome documents specific functionality.
*/
public class DocumentTab extends Tab {
- /**
- * Observer class with extra calls specific to Chrome Documents
- */
- public static class DocumentTabObserver extends EmptyTabObserver {
- /**
- * Called when a Favicon is received for the current document.
- * @param image The favicon image that was received.
- */
- protected void onFaviconReceived(Bitmap image) { }
- }
-
private boolean mDidRestoreState;
/**
@@ -125,19 +110,6 @@ public class DocumentTab extends Tab {
getView().requestFocus();
}
- @Override
- public void onFaviconAvailable(Bitmap image) {
- super.onFaviconAvailable(image);
- if (image == null) return;
- RewindableIterator<TabObserver> observers = getTabObservers();
- while (observers.hasNext()) {
- TabObserver observer = observers.next();
- if (observer instanceof DocumentTabObserver) {
- ((DocumentTabObserver) observer).onFaviconReceived(image);
- }
- }
- }
-
/**
* A web contents delegate for handling opening new windows in Document mode.
*/

Powered by Google App Engine
This is Rietveld 408576698