Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1464623002: Add SkNx_cast(). (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SkNx_cast(). SkNx_cast() can cast between any of our vector types, provided they have the same number of elements. Any types should work with the default implementation, and we can drop in specializations as needed, like the SSE and NEON Sk4f -> Sk4i I included here as an example. To make this work, I made some internal name changes: SkNi<N,T> -> SkNx<N, T> SkNf<N> -> SkNx<N, float> User aliases (Sk4f, Sk16b, etc.) stay the same. We can land this first (it's PS1) if that makes things easier. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/6c221b40680ff933c7b8f2ac3dfa76b5732aee3e

Patch Set 1 #

Patch Set 2 : SkNx_cast #

Patch Set 3 : derp, is stands for _ints_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -336 lines) Patch
M src/core/SkNx.h View 1 9 chunks +139 lines, -111 lines 0 comments Download
M src/opts/SkNx_avx.h View 4 chunks +26 lines, -26 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 11 chunks +92 lines, -87 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 13 chunks +104 lines, -98 lines 0 comments Download
M tests/SkNxTest.cpp View 1 2 8 chunks +25 lines, -14 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464623002/1
5 years, 1 month ago (2015-11-19 21:51:42 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 22:07:43 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464623002/20001
5 years, 1 month ago (2015-11-19 22:52:57 UTC) #8
mtklein_C
This should be the thing to get you going again with float <--> fixed.
5 years, 1 month ago (2015-11-19 23:05:30 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 23:06:30 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464623002/40001
5 years, 1 month ago (2015-11-19 23:12:19 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 23:26:12 UTC) #17
reed1
lgtm
5 years, 1 month ago (2015-11-20 15:46:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464623002/40001
5 years, 1 month ago (2015-11-20 15:47:11 UTC) #20
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:53:23 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6c221b40680ff933c7b8f2ac3dfa76b5732aee3e

Powered by Google App Engine
This is Rietveld 408576698