Chromium Code Reviews Chromium Code Reviews
Issue
14646037:
Enable the new dialog style by default; etc. (Closed)
DescriptionEnable the new dialog style by default; etc.
Enables the new dialog and button styles by default.
Please file any appearance/behavior issues against msw/wittman.
(disable: about:flags "New Dialog Style" or --disable-new-dialog-style)
Mike Wittman and I are mid-audit of Win/CrOS dialogs, expect some glitches:
- Some dialogs will have black/clear borders and need layout adjustments.
- Some other UI will need adjustments to accomodate new button styling.
BUG=166075
TEST=Dialogs and buttons employ their new styling; only minor issues remain.
R=sky@chromium.org,wittman@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200206
Patch Set 1 #Patch Set 2 : Change default buttons with focus, like classic dialogs. #Patch Set 3 : Fix LabelButton preferred size calculations; stack overflow for STYLE_BUTTON. #Patch Set 4 : Fix LabelButton preferred size calculations; stack overflow for STYLE_BUTTON. #
Total comments: 2
Patch Set 5 : Update CustomFrameViewAshTest.ResizeButtonToggleMaximize expectations. #Patch Set 6 : Always test CustomFrameViewAsh, not the new-dialog-style BubbleFrameView. #Patch Set 7 : Split out requisite changes. #Patch Set 8 : Sync and rebase. #
Messages
Total messages: 6 (0 generated)
|
|||||||||||||||||||
