chrome/common/render_messages.h - Issue 14646034: Add onfocuschange to the Extended Search API, with associated isFocused attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/render_messages.h

Issue 14646034: Add onfocuschange to the Extended Search API, with associated isFocused attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using KeyCaptureChange IPC for notification of focus change, and checking if it really changed in t… Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/omnibox_focus_state.h ('K') | « chrome/common/omnibox_focus_state.h ('k') | chrome/renderer/resources/extensions/searchbox_api.js » ('j') | chrome/renderer/resources/extensions/searchbox_api.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/render_messages.h

diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h

index 2758407b2c2c1da090f874bbce94c15676063522..5903a0f5de503d0730f71397e3be3f56b0adf809 100644

--- a/chrome/common/render_messages.h

+++ b/chrome/common/render_messages.h

@@ -119,6 +119,7 @@ IPC_ENUM_TRAITS(ChromeViewHostMsg_GetPluginInfo_Status::Value)

IPC_ENUM_TRAITS(InstantCompleteBehavior)

IPC_ENUM_TRAITS(InstantSizeUnits)

IPC_ENUM_TRAITS(InstantSuggestionType)

+IPC_ENUM_TRAITS(OmniboxFocusChangeReason)

IPC_ENUM_TRAITS(OmniboxFocusState)

IPC_ENUM_TRAITS(search_provider::OSDDType)

IPC_ENUM_TRAITS(search_provider::InstallState)

@@ -346,8 +347,9 @@ IPC_MESSAGE_ROUTED2(ChromeViewMsg_SearchBoxFontInformation,

string16 /* omnibox_font */,

size_t /* omnibox_font_size */)

-IPC_MESSAGE_ROUTED1(ChromeViewMsg_SearchBoxKeyCaptureChanged,

- bool /* is_key_capture_enabled */)

+IPC_MESSAGE_ROUTED2(ChromeViewMsg_SearchBoxKeyCaptureChanged,

samarth 2013/05/13 20:56:53 I'd rename this to SearchBoxFocusChanged

Donn Denman 2013/05/13 23:44:50 Done.

+ OmniboxFocusState /* new_focus_state */,

+ OmniboxFocusChangeReason /* reason */)

IPC_MESSAGE_ROUTED1(ChromeViewMsg_SearchBoxMostVisitedItemsChanged,

std::vector<InstantMostVisitedItemIDPair> /* items */)