chrome/common/omnibox_focus_state.h - Issue 14646034: Add onfocuschange to the Extended Search API, with associated isFocused attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/omnibox_focus_state.h

Issue 14646034: Add onfocuschange to the Extended Search API, with associated isFocused attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using KeyCaptureChange IPC for notification of focus change, and checking if it really changed in t… Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/omnibox_focus_state.h

diff --git a/chrome/common/omnibox_focus_state.h b/chrome/common/omnibox_focus_state.h

index 3bce97479bb984f0f9341114a9dc81cac5d29b5d..398365f7b47d4dd5e1564c726d7bf87bc1ab7c56 100644

--- a/chrome/common/omnibox_focus_state.h

+++ b/chrome/common/omnibox_focus_state.h

@@ -20,4 +20,22 @@ enum OmniboxFocusState {

OMNIBOX_FOCUS_INVISIBLE,

};

+// Reasons why the Omnibox focus state could change.

+enum OmniboxFocusChangeReason {

+ // Includes any explicit changes to focus. (e.g. user clicking to change

+ // focus, user tabbing to change focus, any explicit calls to SetFocus,

+ // etc.)

+ OMNIBOX_FOCUS_CHANGE_EXPLICIT,

+ // Focus changed to restore state from a tab the user switched to.

+ OMNIBOX_FOCUS_CHANGE_TAB_SWITCH,

+ // Focus changed because user started typing. This only happens when focus

+ // state is INVISIBLE (and this results in a change to VISIBLE).

+ OMNIBOX_FOCUS_CHANGE_TYPING,

+ // Focus being established during initialization.

samarth 2013/05/13 20:56:53 This shouldn't be necessary.

Donn Denman 2013/05/13 23:44:50 Done.

+ OMNIBOX_FOCUS_CHANGE_INIT,

+};

#endif // CHROME_COMMON_OMNIBOX_FOCUS_STATE_H_

« chrome/browser/ui/search/instant_controller.cc ('K') | « chrome/browser/ui/search/instant_page.cc ('k') | chrome/common/render_messages.h » ('j') | chrome/common/render_messages.h » ('J')