Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 14643009: Don't discard stderr. (Closed)

Created:
7 years, 7 months ago by szager1
Modified:
7 years, 7 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 1

Patch Set 3 : Remove debugging print statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M subprocess2.py View 1 chunk +0 lines, -1 line 0 comments Download
M tests/subprocess2_test.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
szager1
7 years, 7 months ago (2013-04-30 17:40:12 UTC) #1
M-A Ruel
lgtm, I'd like a test though if possible, if you care.
7 years, 7 months ago (2013-04-30 17:42:38 UTC) #2
szager1
Added test, PTAL
7 years, 7 months ago (2013-04-30 18:38:19 UTC) #3
M-A Ruel
lgtm https://codereview.chromium.org/14643009/diff/3001/tests/subprocess2_test.py File tests/subprocess2_test.py (right): https://codereview.chromium.org/14643009/diff/3001/tests/subprocess2_test.py#newcode335 tests/subprocess2_test.py:335: print r1 remove the print statements.
7 years, 7 months ago (2013-04-30 18:42:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/14643009/3002
7 years, 7 months ago (2013-04-30 18:51:08 UTC) #5
commit-bot: I haz the power
Presubmit check for 14643009-3002 failed and returned exit status 1. INFO:root:Found 2 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 7 months ago (2013-04-30 18:53:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/14643009/3002
7 years, 7 months ago (2013-04-30 18:55:03 UTC) #7
M-A Ruel
On 2013/04/30 18:53:51, I haz the power (commit-bot) wrote: ====================================================================== > FAIL: testMove (__main__.SvnCheckout) > ...
7 years, 7 months ago (2013-04-30 18:55:50 UTC) #8
commit-bot: I haz the power
Presubmit check for 14643009-3002 failed and returned exit status 1. INFO:root:Found 2 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 7 months ago (2013-04-30 18:56:35 UTC) #9
szager1
7 years, 7 months ago (2013-04-30 19:10:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r197419.

Powered by Google App Engine
This is Rietveld 408576698