subprocess2.py - Issue 14643009: Don't discard stderr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess2.py

Issue 14643009: Don't discard stderr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Remove debugging print statements Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: subprocess2.py

diff --git a/subprocess2.py b/subprocess2.py

index 364aace886009ab18322524f6e8f8bc6f97a03d3..1f9c6c99e365ad8a958acae8511d10d0b99aaaf0 100644

--- a/subprocess2.py

+++ b/subprocess2.py

@@ -355,7 +355,6 @@ class Popen(subprocess.Popen):

self._tee_threads(input)

if stdout is not None:

stdout = ''.join(stdout)

- stderr = None

if stderr is not None:

stderr = ''.join(stderr)

return (stdout, stderr)

« no previous file with comments | « no previous file | tests/subprocess2_test.py » ('j') | no next file with comments »