Issue 14642018: Revert 197960 "[chromeos] Remove dependencies of StatisticsProvi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14642018: Revert 197960 "[chromeos] Remove dependencies of StatisticsProvi..." (Closed)

Created:
7 years, 7 months ago by dpapad

Modified:
7 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 197960 "[chromeos] Remove dependencies of StatisticsProvi..." > [chromeos] Remove dependencies of StatisticsProvider on chrome. > > BUG=180711 > R=davemoore@google.com > > Review URL: https://codereview.chromium.org/14643006 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197969

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -553 lines)			Patch
A +	trunk/src/chrome/browser/chromeos/app_mode/kiosk_oem_manifest_parser.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/chromeos/app_mode/kiosk_oem_manifest_parser.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/chromeos/app_mode/kiosk_oem_manifest_parser_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/drive/file_cache.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/drive/file_system_util.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/scoped_gaia_auth_extension.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/wizard_controller.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
A +	trunk/src/chrome/browser/chromeos/system/name_value_pairs_parser.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/chromeos/system/name_value_pairs_parser.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/chromeos/system/name_value_pairs_parser_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/system/statistics_provider.cc	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_chromeos.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
MM	trunk/src/chrome/common/chrome_constants.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
MM	trunk/src/chrome/common/chrome_constants.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
D	trunk/src/chromeos/app_mode/kiosk_oem_manifest_parser.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	trunk/src/chromeos/app_mode/kiosk_oem_manifest_parser.cc	View	1 chunk	+0 lines, -58 lines	0 comments	Download
D	trunk/src/chromeos/app_mode/kiosk_oem_manifest_parser_unittest.cc	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	trunk/src/chromeos/chromeos.gyp	View	5 chunks	+0 lines, -8 lines	0 comments	Download
D	trunk/src/chromeos/chromeos_constants.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	trunk/src/chromeos/chromeos_constants.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	trunk/src/chromeos/system/name_value_pairs_parser.h	View	1 chunk	+0 lines, -83 lines	0 comments	Download
D	trunk/src/chromeos/system/name_value_pairs_parser.cc	View	1 chunk	+0 lines, -149 lines	0 comments	Download
D	trunk/src/chromeos/system/name_value_pairs_parser_unittest.cc	View	1 chunk	+0 lines, -119 lines	0 comments	Download
D	trunk/src/chromeos/test/data/app_mode/kiosk_manifest/kiosk_manifest.json	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r197969.

Expand Messages | Collapse Messages