Issue 14643006: [chromeos] Remove dependencies of StatisticsProvider on chrome.

Issue 14643006: [chromeos] Remove dependencies of StatisticsProvider on chrome. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.

Modified:
7 years, 7 months ago

Reviewers:
davemoore (google), DaveMoore, hshi1

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromeos] Remove dependencies of StatisticsProvider on chrome. BUG=180711 R=davemoore@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197960

Patch Set 1 #

Patch Set 2 : added chromeos_constants #

Patch Set 3 : trybots #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -541 lines)			Patch
D	chrome/browser/chromeos/app_mode/kiosk_oem_manifest_parser.h	View	1 2	1 chunk	+0 lines, -43 lines	0 comments	Download
D	chrome/browser/chromeos/app_mode/kiosk_oem_manifest_parser.cc	View	1 2	1 chunk	+0 lines, -58 lines	0 comments	Download
D	chrome/browser/chromeos/app_mode/kiosk_oem_manifest_parser_unittest.cc	View	1 2	1 chunk	+0 lines, -28 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/scoped_gaia_auth_extension.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller_browsertest.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
D	chrome/browser/chromeos/system/name_value_pairs_parser.h	View		1 chunk	+0 lines, -82 lines	0 comments	Download
D	chrome/browser/chromeos/system/name_value_pairs_parser.cc	View		1 chunk	+0 lines, -149 lines	0 comments	Download
D	chrome/browser/chromeos/system/name_value_pairs_parser_unittest.cc	View		1 chunk	+0 lines, -119 lines	0 comments	Download
M	chrome/browser/chromeos/system/statistics_provider.cc	View	1 2	2 chunks	+7 lines, -10 lines	1 comment	Download
M	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/common/chrome_constants.cc	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
D	chrome/test/data/chromeos/app_mode/kiosk_manifest/kiosk_manifest.json	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
A +	chromeos/app_mode/kiosk_oem_manifest_parser.h	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
A +	chromeos/app_mode/kiosk_oem_manifest_parser.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	chromeos/app_mode/kiosk_oem_manifest_parser_unittest.cc	View	1 2	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chromeos/chromeos.gyp	View	1 2	5 chunks	+8 lines, -0 lines	0 comments	Download
A	chromeos/chromeos_constants.h	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chromeos/chromeos_constants.cc	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
A +	chromeos/system/name_value_pairs_parser.h	View	1 2	3 chunks	+5 lines, -4 lines	0 comments	Download
A +	chromeos/system/name_value_pairs_parser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chromeos/system/name_value_pairs_parser_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chromeos/test/data/app_mode/kiosk_manifest/kiosk_manifest.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hshi1

7 years, 7 months ago (2013-05-02 20:30:07 UTC) #4

Message was sent while issue was closed.

This is breaking build on official GOOGLE_CHROME.

https://codereview.chromium.org/14643006/diff/8001/chrome/browser/chromeos/sy...
File chrome/browser/chromeos/system/statistics_provider.cc (right):

https://codereview.chromium.org/14643006/diff/8001/chrome/browser/chromeos/sy...
chrome/browser/chromeos/system/statistics_provider.cc:196:
chrome::VersionInfo::SetChannel(iter->second);
This is still using chrome::

Expand Messages | Collapse Messages