Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1464133002: Sync the URL constructor with the spec (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync the URL constructor with the spec https://url.spec.whatwg.org/#api This changes the generated code, but ought not be observable, as any call to `new URL(x, urlObject)` will now instead behaves as `new URL(x, urlObject.toString())`. BUG=460722 Committed: https://crrev.com/122f84f37a2ff865c3e76ff99280b24da8f2a2f9 Cr-Commit-Position: refs/heads/master@{#361342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M third_party/WebKit/Source/core/dom/DOMURL.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/URL.idl View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464133002/1
5 years, 1 month ago (2015-11-21 20:02:04 UTC) #2
philipj_slow
PTAL. By getting rid of the URL type from the constructor, this interface will not ...
5 years, 1 month ago (2015-11-21 21:27:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-22 04:51:53 UTC) #6
bashi
bindings/ LGTM
5 years ago (2015-11-24 00:13:21 UTC) #7
philipj_slow
Jochen, can you please review the non-bindings aspect of this, i.e. the API change?
5 years ago (2015-11-24 07:43:16 UTC) #9
haraken
non-owner LGTM
5 years ago (2015-11-24 08:12:45 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-24 13:07:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464133002/1
5 years ago (2015-11-24 13:52:08 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 15:20:21 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-24 15:21:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/122f84f37a2ff865c3e76ff99280b24da8f2a2f9
Cr-Commit-Position: refs/heads/master@{#361342}

Powered by Google App Engine
This is Rietveld 408576698