Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: third_party/WebKit/Source/core/dom/URL.idl

Issue 1464133002: Sync the URL constructor with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMURL.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/URL.idl
diff --git a/third_party/WebKit/Source/core/dom/URL.idl b/third_party/WebKit/Source/core/dom/URL.idl
index 8bd952734b4b7d3621bb795cb31ec216c898639b..124d9ce412a9ffa6b6aedc71d7535fb5796f0de4 100644
--- a/third_party/WebKit/Source/core/dom/URL.idl
+++ b/third_party/WebKit/Source/core/dom/URL.idl
@@ -27,11 +27,7 @@
// https://url.spec.whatwg.org/#url
[
- // TODO(philipj): There should only be one constructor:
- // Constructor(USVString url, optional USVString base)
- Constructor(USVString url),
- Constructor(USVString url, USVString base),
- Constructor(USVString url, URL base),
+ Constructor(USVString url, optional USVString base),
Exposed=(Window,Worker),
ImplementedAs=DOMURL,
RaisesException=Constructor,
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMURL.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698