[debugger] flood function for stepping before calling it.

[debugger] flood function for stepping before calling it.

R=verwaest@chromium.org

Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}

Committed: https://crrev.com/81e131ce4889205570e870cf50c55c7ad61aa376
Cr-Commit-Position: refs/heads/master@{#32339}

[Yang, 2015-11-20 13:13:54]

yangguo@chromium.org changed reviewers:
+ bmeurer@google.com

[Yang, 2015-11-20 13:13:54]

Benedikt, could you take a look as well before I start porting?

[Yang, 2015-11-20 13:27:03]

yangguo@chromium.org changed reviewers:
+ mstarzinger@chromium.org
- bmeurer@google.com

[Yang, 2015-11-20 13:27:04]

Michael, Benedikt wants you to review this :)

[Toon Verwaest, 2015-11-24 15:03:41]

lgtm

[Michael Starzinger, 2015-11-25 14:28:14]

LGTM with comments.

https://codereview.chromium.org/1463803002/diff/100001/src/builtins.h
File src/builtins.h (right):

https://codereview.chromium.org/1463803002/diff/100001/src/builtins.h#newcode356
src/builtins.h:356: static void Generate_FloodFunctionIfStepping(MacroAssembler*
masm,
I cannot find the implementation of this method, are these builtins still
needed? Looks like leftover from a previous version.

https://codereview.chromium.org/1463803002/diff/100001/src/js/macros.py
File src/js/macros.py (left):

https://codereview.chromium.org/1463803002/diff/100001/src/js/macros.py#oldco...
src/js/macros.py:316: macro DEBUG_IS_STEPPING(function) = (%_DebugIsActive() !=
0 && %DebugCallbackSupportsStepping(function));
It looks like DebugCallbackSupportsStepping has become unused, can we drop it?

[Yang, 2015-11-25 14:34:26]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-25 14:34:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1463803002/#ps120001
(title: "address comments")

[commit-bot: I haz the power, 2015-11-25 14:34:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463803002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463803002/120001

[Yang, 2015-11-25 14:34:36]

On 2015/11/25 14:28:14, Michael Starzinger wrote:
> LGTM with comments.
> 
> https://codereview.chromium.org/1463803002/diff/100001/src/builtins.h
> File src/builtins.h (right):
> 
>
https://codereview.chromium.org/1463803002/diff/100001/src/builtins.h#newcode356
> src/builtins.h:356: static void
Generate_FloodFunctionIfStepping(MacroAssembler*
> masm,
> I cannot find the implementation of this method, are these builtins still
> needed? Looks like leftover from a previous version.
> 
> https://codereview.chromium.org/1463803002/diff/100001/src/js/macros.py
> File src/js/macros.py (left):
> 
>
https://codereview.chromium.org/1463803002/diff/100001/src/js/macros.py#oldco...
> src/js/macros.py:316: macro DEBUG_IS_STEPPING(function) = (%_DebugIsActive()
!=
> 0 && %DebugCallbackSupportsStepping(function));
> It looks like DebugCallbackSupportsStepping has become unused, can we drop it?

Thanks for catching these. Uploaded new patch set.

[commit-bot: I haz the power, 2015-11-25 15:45:39]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-11-25 15:45:52]

Patchset 7 (id:??) landed as
https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}

[Michael Achenbach, 2015-11-25 19:24:12]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1474943005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Yang, 2015-11-26 09:27:07]

Description was changed from

==========
[debugger] flood function for stepping before calling it.

R=verwaest@chromium.org

Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}
==========

to

==========
[debugger] flood function for stepping before calling it.

R=verwaest@chromium.org

Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}
==========

[Yang, 2015-11-26 13:30:05]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-26 13:30:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1463803002/#ps140001
(title: "fix")

[commit-bot: I haz the power, 2015-11-26 13:30:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463803002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463803002/140001

[commit-bot: I haz the power, 2015-11-26 14:12:09]

Description was changed from

==========
[debugger] flood function for stepping before calling it.

R=verwaest@chromium.org

Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}
==========

to

==========
[debugger] flood function for stepping before calling it.

R=verwaest@chromium.org

Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}
==========

[commit-bot: I haz the power, 2015-11-26 14:12:10]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-11-26 14:12:24]

Description was changed from

==========
[debugger] flood function for stepping before calling it.

R=verwaest@chromium.org

Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}
==========

to

==========
[debugger] flood function for stepping before calling it.

R=verwaest@chromium.org

Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266
Cr-Commit-Position: refs/heads/master@{#32285}

Committed: https://crrev.com/81e131ce4889205570e870cf50c55c7ad61aa376
Cr-Commit-Position: refs/heads/master@{#32339}
==========

[commit-bot: I haz the power, 2015-11-26 14:12:25]

Patchset 8 (id:??) landed as
https://crrev.com/81e131ce4889205570e870cf50c55c7ad61aa376
Cr-Commit-Position: refs/heads/master@{#32339}