Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Unified Diff: src/assembler.h

Issue 1463803002: [debugger] flood function for stepping before calling it. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.h
diff --git a/src/assembler.h b/src/assembler.h
index 40df858331589a7793250d1cc94ea5d62f5e807e..6765211acc40926d8199f586681b7374bbf058a8 100644
--- a/src/assembler.h
+++ b/src/assembler.h
@@ -1004,7 +1004,7 @@ class ExternalReference BASE_EMBEDDED {
Address address() const { return reinterpret_cast<Address>(address_); }
// Used to check if single stepping is enabled in generated code.
- static ExternalReference debug_step_in_fp_address(Isolate* isolate);
+ static ExternalReference debug_last_step_action_address(Isolate* isolate);
#ifndef V8_INTERPRETED_REGEXP
// C functions called from RegExp generated code.
@@ -1154,8 +1154,11 @@ class CallWrapper {
virtual void BeforeCall(int call_size) const = 0;
// Called just after emitting a call, i.e., at the return site for the call.
virtual void AfterCall() const = 0;
+ // Return whether call needs to check for debug stepping.
+ virtual bool NeedsDebugStepCheck() const { return false; }
};
+
class NullCallWrapper : public CallWrapper {
public:
NullCallWrapper() { }
@@ -1165,6 +1168,16 @@ class NullCallWrapper : public CallWrapper {
};
+class CheckDebugStepCallWrapper : public CallWrapper {
+ public:
+ CheckDebugStepCallWrapper() {}
+ virtual ~CheckDebugStepCallWrapper() {}
+ virtual void BeforeCall(int call_size) const {}
+ virtual void AfterCall() const {}
+ virtual bool NeedsDebugStepCheck() const { return true; }
+};
+
+
// -----------------------------------------------------------------------------
// Constant pool support
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698