third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp - Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/tests/VisualViewportTest.cpp ('K') | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

index 5759dfe57d573bdd1ecbcfa6c9e3b0a42145f2a4..bf380607c953364263b62f50852b5228331a226d 100644

--- a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

@@ -368,7 +368,7 @@ TEST_F(WebPluginContainerTest, GestureLongPressReachesPlugin)

EXPECT_EQ(WebInputEvent::Undefined, testPlugin->getLastInputEventType());

// Next, send an event that does hit the plugin, and verify it does receive it.

- WebRect rect = pluginContainerOneElement.boundsInViewportSpace();

+ WebRect rect = pluginContainerOneElement.boundsInViewport();

event.x = rect.x + rect.width / 2;

event.y = rect.y + rect.height / 2;

@@ -395,7 +395,7 @@ TEST_F(WebPluginContainerTest, IsRectTopmostTest)

toWebPluginContainerImpl(getWebPluginContainer(webView, WebString::fromUTF8("translated-plugin")));

pluginContainerImpl->setFrameRect(IntRect(0, 0, 300, 300));

- WebRect rect = pluginContainerImpl->element().boundsInViewportSpace();

+ WebRect rect = pluginContainerImpl->element().boundsInViewport();

EXPECT_TRUE(pluginContainerImpl->isRectTopmost(rect));

// Cause the plugin's frame to be detached.