third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/testing/Internals.idl ('K') | « third_party/WebKit/Source/web/WebElement.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 6781d0b1bbe1645abb09b0e5b8eac41ce11ca83c..0c31b2fc20cb7b56bc1e839a485b4c4a3d5dd3da 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -1398,7 +1398,8 @@ TEST_P(ParameterizedVisualViewportTest, ElementBoundsInViewportSpaceAccountsForV

visualViewport.setScale(2);

visualViewport.setLocation(scrollDelta);

- IntRect boundsInViewport = inputElement->boundsInViewportSpace();

+ IntRect boundsInViewport = inputElement->boundsInViewport();

+ boundsInViewport.scale(1.f / 2);

bokan 2015/11/24 20:59:24 Please instead create an expectedBounds = bounds,

oshima 2015/11/24 23:42:10 Done.

EXPECT_POINT_EQ(IntPoint(bounds.location() - scrollDelta),

boundsInViewport.location());