Return VisualViewport coords in boundsInViewportSpace

components/autofill/content/renderer/password_autofill_agent.cc

Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 845e52c748f188605e7d135cbb4c07720ebc1a25..009942941a8d788f66afd546bd3543fd020c07f6 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -1420,7 +1420,6 @@ bool PasswordAutofillAgent::ShowSuggestionPopup(
     DCHECK(iter != web_input_to_password_info_.end());
     selected_element = iter->second.password_field;
   }
-  gfx::Rect bounding_box(selected_element.boundsInViewportSpace());
 
   blink::WebInputElement username;
   if (!show_on_password_field || !user_input.isPasswordField()) {
@@ -1430,12 +1429,6 @@ bool PasswordAutofillAgent::ShowSuggestionPopup(
       web_element_to_password_info_key_.find(user_input);
   DCHECK(key_it != web_element_to_password_info_key_.end());
 
-  float scale =
-      render_frame()->GetRenderView()->GetWebView()->pageScaleFactor();
-  gfx::RectF bounding_box_scaled(bounding_box.x() * scale,
-                                 bounding_box.y() * scale,
-                                 bounding_box.width() * scale,
-                                 bounding_box.height() * scale);
   int options = 0;
   if (show_all)
     options |= SHOW_ALL;
@@ -1444,9 +1437,12 @@ bool PasswordAutofillAgent::ShowSuggestionPopup(
   base::string16 username_string(
       username.isNull() ? base::string16()
                         : static_cast<base::string16>(user_input.value()));
+
+  blink::WebRect bounding_box_in_viewport = selected_element.boundsInViewport();

[vabr (Chromium), 2015/11/24 09:12:27]

ditto

[oshima, 2015/11/24 23:42:10]

Done.

+
   Send(new AutofillHostMsg_ShowPasswordSuggestions(
       routing_id(), key_it->second, field.text_direction, username_string,
-      options, bounding_box_scaled));
+      options, gfx::RectF(bounding_box_in_viewport)));
   username_query_prefix_ = username_string;
   return CanShowSuggestion(fill_data, username_string, show_all);
 }