Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7850)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 1463723003: Return VisualViewport coords in boundsInViewportSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index f15a5806089307374c129c07574cdb94b8797764..5cc0ce2751e1e88446d1c150721ee9b7d472defa 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -729,10 +729,6 @@ void AutofillAgent::QueryAutofillSuggestions(
if (datalist_only)
field.should_autocomplete = false;
- gfx::RectF bounding_box_scaled = form_util::GetScaledBoundingBox(
- render_frame()->GetRenderView()->GetWebView()->pageScaleFactor(),
- &element_);
-
std::vector<base::string16> data_list_values;
std::vector<base::string16> data_list_labels;
const WebInputElement* input_element = toWebInputElement(&element);
@@ -751,8 +747,11 @@ void AutofillAgent::QueryAutofillSuggestions(
data_list_values,
data_list_labels));
+ blink::WebRect bounding_box_in_viewport = element_.boundsInViewport();
vabr (Chromium) 2015/11/24 09:12:27 nit: Why not just inline it below?
oshima 2015/11/24 23:42:10 Done.
+
Send(new AutofillHostMsg_QueryFormFieldAutofill(
- routing_id(), autofill_query_id_, form, field, bounding_box_scaled));
+ routing_id(), autofill_query_id_, form, field,
+ gfx::RectF(bounding_box_in_viewport)));
}
void AutofillAgent::FillFieldWithValue(const base::string16& value,

Powered by Google App Engine
This is Rietveld 408576698