Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: chrome/browser/resources/options/browser_options.html

Issue 146363002: Linux Aura: Use system title bar is now set by preference, not flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert adding argument to FrameTypeChanged everywhere (thanks sky). Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.html
diff --git a/chrome/browser/resources/options/browser_options.html b/chrome/browser/resources/options/browser_options.html
index 76b98da36c2be58c45d50892dbc5e167e6d793bb..5f4c409f98cd6f94835a0f318f533cf90030b017 100644
--- a/chrome/browser/resources/options/browser_options.html
+++ b/chrome/browser/resources/options/browser_options.html
@@ -82,7 +82,7 @@
</span>
</span>
</div>
-<if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx">
+<if expr="is_posix and not pp_ifdef('chromeos') and not is_macosx">
msw 2014/02/06 00:50:27 Will this break GTK, which is shipping for M-24?
Elliot Glaysher 2014/02/06 00:52:30 Theoretically, this shouldn't.
Matt Giuca 2014/02/11 04:57:43 Tested on GTK; it still shows the checkbox. (Not s
msw 2014/02/11 19:32:59 I wasn't sure if we want this on GTK or not. You a
Matt Giuca 2014/02/12 01:09:18 This is already a GTK feature. We aren't trying to
<div class="checkbox"><label>
<input id="show-window-decorations" type="checkbox"
pref="browser.custom_chrome_frame" metric="Options_CustomFrame"

Powered by Google App Engine
This is Rietveld 408576698