Linux Aura: Use system title bar is now set by preference, not flag.

chrome/browser/resources/options/browser_options.html

 <div id="settings" class="page" hidden>
   <header>
     <h1 i18n-content="settingsTitle"></h1>
   </header>
   <include src="reset_profile_settings_banner.html">
 <if expr="not pp_ifdef('chromeos')">
   <include src="sync_section.html">
 </if>
 <if expr="pp_ifdef('chromeos')">
   <section>
@@ skipping 64 matching lines @@
         <span>
           <label for="show-bookmark-bars"
               i18n-content="toolbarShowBookmarksBar">
           </label>
           <span class="controlled-setting-indicator"
               pref="bookmark_bar.show_on_all_tabs">
           </span>
         </span>
       </span>
     </div>
-<if expr="not pp_ifdef('toolkit_views') and is_posix and not is_macosx">
+<if expr="is_posix and not pp_ifdef('chromeos') and not is_macosx">

[msw, 2014/02/06 00:50:27]

Will this break GTK, which is shipping for M-24?

[Elliot Glaysher, 2014/02/06 00:52:30]

Theoretically, this shouldn't.

[Matt Giuca, 2014/02/11 04:57:43]

Tested on GTK; it still shows the checkbox. (Not sure what the concern was.)

[msw, 2014/02/11 19:32:59]

I wasn't sure if we want this on GTK or not. You addressed my
browser_command_controller.cc nits to exclude GTK, but then you noted that the
checkbox is still available on GTK here. I'm still a bit confused.

[Matt Giuca, 2014/02/12 01:09:18]

This is already a GTK feature. We aren't trying to remove it on GTK, just add it
on Aura. (Maybe that explains the confusion?)

     <div class="checkbox"><label>
         <input id="show-window-decorations" type="checkbox"
             pref="browser.custom_chrome_frame" metric="Options_CustomFrame"
             inverted_pref>
         <span i18n-content="showWindowDecorations"></span>
     </label></div>
 </if>
   </section>
 <if expr="pp_ifdef('chromeos')">
   <section>
@@ skipping 787 matching lines @@
     </div>
   </section>
   </div>  <!-- advanced-settings-container -->
   </div>  <!-- advanced-settings -->
   <footer>
     <button id="advanced-settings-expander" class="link-button"
         i18n-content="showAdvancedSettings">
     </button>
   </footer>
   </div>