Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 14636002: Make TypeMask an interface and start hiding implementation details of FlatTypeMask. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 22167)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1693,13 +1693,11 @@
}
void registerForeignType(HType type) {
- // TODO(kasperl): This looks shaky. It makes sense if the type is
- // exact, but otherwise we should be registering more types as
- // instantiated. We should find a way of using something along the
- // lines of the NativeEnqueuerBase.processNativeBehavior method.
if (type.isUnknown()) return;
TypeMask mask = type.computeMask(compiler);
- world.registerInstantiatedClass(mask.base.element, work.resolutionTree);
+ for (ClassElement cls in mask.containedClasses(compiler)) {
+ world.registerInstantiatedClass(cls, work.resolutionTree);
+ }
}
visitForeign(HForeign node) {

Powered by Google App Engine
This is Rietveld 408576698