Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/types.dart

Issue 14636002: Make TypeMask an interface and start hiding implementation details of FlatTypeMask. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/types.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/types.dart (revision 22167)
+++ sdk/lib/_internal/compiler/implementation/ssa/types.dart (working copy)
@@ -18,43 +18,37 @@
return isNullable ? HType.NULL : HType.CONFLICTING;
}
- Element element = mask.base.element;
- JavaScriptBackend backend = compiler.backend;
- if (element == compiler.intClass || element == backend.jsIntClass) {
+ if (mask.containsOnlyInt(compiler)) {
return isNullable ? HType.INTEGER_OR_NULL : HType.INTEGER;
- } else if (element == compiler.numClass
- || element == backend.jsNumberClass) {
- return isNullable ? HType.NUMBER_OR_NULL : HType.NUMBER;
- } else if (element == compiler.doubleClass
- || element == backend.jsDoubleClass) {
+ } else if (mask.containsOnlyDouble(compiler)) {
return isNullable ? HType.DOUBLE_OR_NULL : HType.DOUBLE;
- } else if (element == compiler.stringClass
- || element == backend.jsStringClass) {
+ } else if (mask.containsOnlyNum(compiler)) {
+ return isNullable ? HType.NUMBER_OR_NULL : HType.NUMBER;
+ } else if (mask.containsOnlyString(compiler)) {
return isNullable ? HType.STRING_OR_NULL : HType.STRING;
- } else if (element == compiler.boolClass
- || element == backend.jsBoolClass) {
+ } else if (mask.containsOnlyBool(compiler)) {
return isNullable ? HType.BOOLEAN_OR_NULL : HType.BOOLEAN;
- } else if (element == compiler.nullClass
- || element == backend.jsNullClass) {
+ } else if (mask.containsOnlyNull(compiler)) {
return HType.NULL;
}
// TODO(kasperl): A lot of the code in the system currently
// expects the top type to be 'unknown'. I'll rework this.
- if (element == compiler.objectClass || element == compiler.dynamicClass) {
+ if (mask.containsAll(compiler)) {
return isNullable ? HType.UNKNOWN : HType.NON_NULL;
}
+ JavaScriptBackend backend = compiler.backend;
if (!isNullable) {
- if (element == backend.jsIndexableClass) {
+ if (mask.containsOnly(backend.jsIndexableClass)) {
return HType.INDEXABLE_PRIMITIVE;
- } else if (element == backend.jsArrayClass) {
+ } else if (mask.containsOnly(backend.jsArrayClass)) {
return HType.READABLE_ARRAY;
- } else if (element == backend.jsMutableArrayClass) {
+ } else if (mask.containsOnly(backend.jsMutableArrayClass)) {
return HType.MUTABLE_ARRAY;
- } else if (element == backend.jsFixedArrayClass) {
+ } else if (mask.containsOnly(backend.jsFixedArrayClass)) {
return HType.FIXED_ARRAY;
- } else if (element == backend.jsExtendableArrayClass) {
+ } else if (mask.containsOnly(backend.jsExtendableArrayClass)) {
return HType.EXTENDABLE_ARRAY;
}
}

Powered by Google App Engine
This is Rietveld 408576698