Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1463503003: telemetry: Remove Flash tab-switching benchmarks. (Closed)

Created:
5 years, 1 month ago by erikchen
Modified:
5 years ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

telemetry: Remove Flash tab-switching benchmarks. These tests have never worked on perf bots, and are currently disabled. See https://code.google.com/p/chromium/issues/detail?id=530405#c10 for more details. BUG=530405 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/feffc2f4474c48d6cee300a0c9b066de6962a127 Cr-Commit-Position: refs/heads/master@{#361224}

Patch Set 1 #

Patch Set 2 : Remove dead code. #

Patch Set 3 : Remove more dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -79 lines) Patch
M tools/perf/benchmarks/tab_switching.py View 1 1 chunk +0 lines, -25 lines 0 comments Download
D tools/perf/page_sets/data/flash_energy_cases.json View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D tools/perf/page_sets/data/flash_energy_cases_000.wpr.sha1 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/flash_energy_cases.py View 1 2 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
erikchen
sullivan: Please review.
5 years, 1 month ago (2015-11-20 00:57:24 UTC) #2
erikchen
On 2015/11/20 00:57:24, erikchen wrote: > sullivan: Please review. Nevermind, not necessary, as per: https://code.google.com/p/chromium/issues/detail?id=530405#c10 ...
5 years, 1 month ago (2015-11-20 01:32:18 UTC) #3
sullivan
On 2015/11/20 01:32:18, erikchen wrote: > On 2015/11/20 00:57:24, erikchen wrote: > > sullivan: Please ...
5 years ago (2015-11-23 16:09:27 UTC) #5
erikchen
sullivan: Done. PTAL
5 years ago (2015-11-23 19:22:47 UTC) #7
sullivan
lgtm Thanks!
5 years ago (2015-11-23 19:25:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463503003/40001
5 years ago (2015-11-23 19:35:17 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 00:11:54 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-24 00:13:22 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/feffc2f4474c48d6cee300a0c9b066de6962a127
Cr-Commit-Position: refs/heads/master@{#361224}

Powered by Google App Engine
This is Rietveld 408576698