Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1144383005: Perf tests for Plugin Power Saver take 2. (Closed)

Created:
5 years, 6 months ago by Dan Beam
Modified:
5 years, 6 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perf tests for Plugin Power Saver take 2. This time, with more throttled plugins! I'm adding 2 different benchmarks: 1) some popular sites that have throttled foreground plugins 2) a control site that we should also do well on and creating tests that will run both benchmarks with and without PPS. R=sullivan@chromium.org BUG=478918 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/754b802e2d3c65d15a93a0ffcb62ecca1001da1e Cr-Commit-Position: refs/heads/master@{#332270}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sullivan@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -5 lines) Patch
M tools/perf/benchmarks/power.py View 1 1 chunk +62 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/tab_switching.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/perf/page_sets/data/plugin_power_saver.json View 1 chunk +3 lines, -3 lines 0 comments Download
A tools/perf/page_sets/data/plugin_power_saver_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/throttled_plugins.json View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/throttled_plugins_004.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/plugin_power_saver.py View 1 chunk +16 lines, -0 lines 0 comments Download
A tools/perf/page_sets/throttled_plugins.py View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Dan Beam
5 years, 6 months ago (2015-05-30 02:19:41 UTC) #1
sullivan
lgtm https://codereview.chromium.org/1144383005/diff/1/tools/perf/benchmarks/power.py File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/1144383005/diff/1/tools/perf/benchmarks/power.py#newcode76 tools/perf/benchmarks/power.py:76: class PowerPPSControlDisabled(perf_benchmark.PerfBenchmark): The class-level pydoc for these each ...
5 years, 6 months ago (2015-06-01 14:20:49 UTC) #2
Dan Beam
https://codereview.chromium.org/1144383005/diff/1/tools/perf/benchmarks/power.py File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/1144383005/diff/1/tools/perf/benchmarks/power.py#newcode76 tools/perf/benchmarks/power.py:76: class PowerPPSControlDisabled(perf_benchmark.PerfBenchmark): On 2015/06/01 14:20:48, sullivan wrote: > The ...
5 years, 6 months ago (2015-06-01 17:27:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144383005/20001
5 years, 6 months ago (2015-06-01 17:28:28 UTC) #6
sullivan
lgtm
5 years, 6 months ago (2015-06-01 17:28:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67194)
5 years, 6 months ago (2015-06-01 17:43:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144383005/20001
5 years, 6 months ago (2015-06-01 19:21:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67251)
5 years, 6 months ago (2015-06-01 19:36:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144383005/20001
5 years, 6 months ago (2015-06-01 21:17:25 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-01 21:24:53 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/754b802e2d3c65d15a93a0ffcb62ecca1001da1e Cr-Commit-Position: refs/heads/master@{#332270}
5 years, 6 months ago (2015-06-01 21:26:59 UTC) #17
RyanS
5 years, 6 months ago (2015-06-03 22:29:57 UTC) #18
Message was sent while issue was closed.
Looks like this had up to about a 15-20% impact depending on the platform, which
is pretty encouraging. Thanks for putting this together!

Powered by Google App Engine
This is Rietveld 408576698