Replace MockConnectionToClient with FakeConnectionToClient

Replace MockConnectionToClient with FakeConnectionToClient

MockConnectionToClient is hard to use and adds a lot of boilerplate in
tests. Replacing it with FakeConnectionToClient will make it easier
to make changes in the ConnectionToClient interface.

BUG=547158
Committed: https://crrev.com/60082fbfeef5936a19bf22a3e31edf2614386e1e
Cr-Commit-Position: refs/heads/master@{#361442}

[Sergey Ulanov, 2015-11-23 22:36:34]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2015-11-23 22:36:40]

Patchset #1 (id:20001) has been deleted

[Sergey Ulanov, 2015-11-23 22:37:55]

Patchset #1 (id:40001) has been deleted

[Sergey Ulanov, 2015-11-23 22:48:15]

Description was changed from

==========
Replace MockConnectionToClient with FakeConnectionToClient
==========

to

==========
Replace MockConnectionToClient with FakeConnectionToClient

MockConnectionToClient is hard to use and adds a lot of boilerplate in 
tests. Replacing it with FakeConnectionToClient will make it easier
to make changes in the ConnectionToClient interface.

BUG=547158
==========

[Sergey Ulanov, 2015-11-23 22:48:15]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-11-24 00:38:09]

LGTM with one suggestion.

https://codereview.chromium.org/1463293002/diff/60001/remoting/host/chromotin...
File remoting/host/chromoting_host_unittest.cc (right):

https://codereview.chromium.org/1463293002/diff/60001/remoting/host/chromotin...
remoting/host/chromoting_host_unittest.cc:333: // Expect that a client is
disconnected, after a given expectation. The given
Nit: No comma needed.

https://codereview.chromium.org/1463293002/diff/60001/remoting/protocol/fake_...
File remoting/protocol/fake_connection_to_client.cc (right):

https://codereview.chromium.org/1463293002/diff/60001/remoting/protocol/fake_...
remoting/protocol/fake_connection_to_client.cc:34: if (is_connected_) {
Do we have tests that rely on being able to call this in an unconnected state,
or would it be better to DCHECK this? It seems strange to have this logic in a
Fake class, since the real class may or may not duplicate it.

[Sergey Ulanov, 2015-11-24 01:21:09]

https://codereview.chromium.org/1463293002/diff/60001/remoting/host/chromotin...
File remoting/host/chromoting_host_unittest.cc (right):

https://codereview.chromium.org/1463293002/diff/60001/remoting/host/chromotin...
remoting/host/chromoting_host_unittest.cc:333: // Expect that a client is
disconnected, after a given expectation. The given
On 2015/11/24 00:38:09, Jamie wrote:
> Nit: No comma needed.

Done.

https://codereview.chromium.org/1463293002/diff/60001/remoting/protocol/fake_...
File remoting/protocol/fake_connection_to_client.cc (right):

https://codereview.chromium.org/1463293002/diff/60001/remoting/protocol/fake_...
remoting/protocol/fake_connection_to_client.cc:34: if (is_connected_) {
On 2015/11/24 00:38:09, Jamie wrote:
> Do we have tests that rely on being able to call this in an unconnected state,
> or would it be better to DCHECK this? It seems strange to have this logic in a
> Fake class, since the real class may or may not duplicate it.

Good point. Replaced it with a CHECK(). There are no tests that depend on this
behavior.

[Jamie, 2015-11-24 01:23:45]

lgtm

[Sergey Ulanov, 2015-11-24 20:12:55]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-11-24 20:13:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463293002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463293002/80001

[commit-bot: I haz the power, 2015-11-24 21:12:56]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2015-11-24 21:13:52]

Patchset 2 (id:??) landed as
https://crrev.com/60082fbfeef5936a19bf22a3e31edf2614386e1e
Cr-Commit-Position: refs/heads/master@{#361442}