Simplify It2Me host shutdown

Simplify It2Me host shutdown

Previously It2Me host was stopped asynchronoulsy, which makes the
shutdown more complicated. Now it's synchronous and is significantly
simpler.
Also removed ChromotingHost::RejectAuthenticatingClient() which is no
longer needed.

Committed: https://crrev.com/21c899eab46fc830099ba9fb7f32f9ba938a876a
Cr-Commit-Position: refs/heads/master@{#361362}

[Sergey Ulanov, 2015-11-20 00:17:27]

sergeyu@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Sergey Ulanov, 2015-11-20 00:22:55]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2015-11-23 22:26:16]

ping

[Lambros, 2015-11-23 22:44:48]

lgtm

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/chromotin...
File remoting/host/chromoting_host.cc (right):

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/chromotin...
remoting/host/chromoting_host.cc:191: if (other_client != client)  {
nit: remove a space before {

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
File remoting/host/it2me/it2me_host.h (right):

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_host.h:76: // Disconnects the host, ready for
tear-down.
Disconnects and shuts down the host?

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_host.h:77: // Also called internally, from the network
thread.
Remove this comment, now that it's only called from the main thread.

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
File remoting/host/it2me/it2me_native_messaging_host_main.cc (right):

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_native_messaging_host_main.cc:81:
base::GetLinuxDistro();
Is this related to this CL ?

[Sergey Ulanov, 2015-11-23 22:59:44]

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/chromotin...
File remoting/host/chromoting_host.cc (right):

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/chromotin...
remoting/host/chromoting_host.cc:191: if (other_client != client)  {
On 2015/11/23 22:44:48, Lambros wrote:
> nit: remove a space before {

Done.

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
File remoting/host/it2me/it2me_host.h (right):

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_host.h:76: // Disconnects the host, ready for
tear-down.
On 2015/11/23 22:44:48, Lambros wrote:
> Disconnects and shuts down the host?

Done.

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_host.h:77: // Also called internally, from the network
thread.
On 2015/11/23 22:44:48, Lambros wrote:
> Remove this comment, now that it's only called from the main thread.

removed this line.

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
File remoting/host/it2me/it2me_native_messaging_host_main.cc (right):

https://codereview.chromium.org/1458323002/diff/20001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_native_messaging_host_main.cc:81:
base::GetLinuxDistro();
On 2015/11/23 22:44:48, Lambros wrote:
> Is this related to this CL ?

Right. I had to add it to make it possible to test this change change with Debug
build.

[Sergey Ulanov, 2015-11-23 22:59:49]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-11-23 22:59:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/1458323002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-11-23 23:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458323002/40001

[commit-bot: I haz the power, 2015-11-24 01:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 01:14:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-11-24 01:16:28]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-11-24 01:19:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458323002/40001

[commit-bot: I haz the power, 2015-11-24 03:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:57:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-11-24 16:14:57]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-11-24 16:15:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458323002/40001

[commit-bot: I haz the power, 2015-11-24 16:40:03]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-11-24 16:41:14]

Patchset 2 (id:??) landed as
https://crrev.com/21c899eab46fc830099ba9fb7f32f9ba938a876a
Cr-Commit-Position: refs/heads/master@{#361362}