Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463123002: - Display a pseudo-receiver for static function activations. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Display a pseudo-receiver for static function activations. - Add missing breadcrumbs to class heirarchy, flags and timetime view. - Truncate large objects by default so we can look at them without falling over. - Demangle local variable names. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/c44419805c24b9c91eb4c65c579f7d9810b7b9b5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -54 lines) Patch
M runtime/observatory/lib/src/elements/class_ref.dart View 1 chunk +18 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.html View 1 chunk +27 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.html View 1 chunk +4 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +7 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/elements/flag_list.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.html View 1 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 4 chunks +27 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_ref.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_ref.html View 1 chunk +32 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.dart View 3 chunks +10 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.html View 1 chunk +16 lines, -14 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 4 chunks +15 lines, -0 lines 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 3 chunks +9 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-20 00:01:55 UTC) #2
rmacnak
Changed "this" to <class> or <library> Fix large objects when expanding instance refs as well ...
5 years ago (2015-11-24 19:33:07 UTC) #3
turnidge
lgtm
5 years ago (2015-11-24 19:35:58 UTC) #4
rmacnak
5 years ago (2015-11-24 20:39:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c44419805c24b9c91eb4c65c579f7d9810b7b9b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698