Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1463123002: - Display a pseudo-receiver for static function activations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 8f5f7a40fd9a0eabf8e36847fbf9387a741219c4..8c9717faa4b309ea17fb9a407a6719bcf3440355 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -4,6 +4,11 @@
part of service;
+// Some value smaller than the object ring, so requesting a large array
+// doesn't result in an expired ref because the elements lapped it in the
+// object ring.
+const int kDefaultFieldLimit = 100;
+
/// Helper function for canceling a Future<StreamSubscription>.
Future cancelFutureSubscription(
Future<StreamSubscription> subscriptionFuture) async {
@@ -284,6 +289,7 @@ abstract class ServiceObject extends Observable {
Future<ObservableMap> _fetchDirect() {
Map params = {
'objectId': id,
+ 'count': kDefaultFieldLimit,
};
return isolate.invokeRpcNoUpgrade('getObject', params);
}
@@ -1288,6 +1294,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
}
Map params = {
'objectId': objectId,
+ 'count': kDefaultFieldLimit,
};
return isolate.invokeRpc('getObject', params);
}
@@ -2639,6 +2646,14 @@ class ServiceFunction extends HeapObject with Coverage {
icDataArray = map['_icDataArray'];
field = map['_field'];
}
+
+ ServiceFunction get homeMethod {
+ var m = this;
+ while (m.dartOwner is ServiceFunction) {
+ m = m.dartOwner;
+ }
+ return m;
+ }
}
« no previous file with comments | « runtime/observatory/lib/src/elements/timeline_page.html ('k') | runtime/observatory/tests/ui/inspector.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698