Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 14631021: Revert 199625 "Remove ENABLE_MESSAGE_CENTER" (Closed)

Created:
7 years, 7 months ago by Nico
Modified:
7 years, 7 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 199625 "Remove ENABLE_MESSAGE_CENTER" Caused a static initializer on Linux: # message_center_constants.cc __i686.get_pc_thunk.cx (Not on Mac though. The SkGetColor() macro has a comment about it not adding a static initializer on release builds, so maybe it's the float-int-multiplication? I don't have a linux box around to check, sorry.) > Remove ENABLE_MESSAGE_CENTER > > Next step on re-factoring Notifications. This will bring the MessageCenter classes, most important message_center::Notification, into build on all systems, including those where the MessageCenter is not yet appearign in UI. This will allow to start using this Notification class in client code and remove the old Notification class defined in chrome/browser/notificaitons/notification.h > > That will allow the clients that already use Rich Notifications to use richer data type support, for example supply an image bits for a Notification (as in Snapshot notifications). > > This also removes a lot of compile-time @ifdefs and replaces them with checking a runtime flag which we already have anyways. > > On Android and iOS, the MessageCenter is not compiled in, for the size concerns and uncertain story for notifications in general - the existing ENABLE_NOTIFICATIONS define is used for that. > > BUG=174164 > > Review URL: https://chromiumcodereview.appspot.com/15025002 TBR=dimich@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -338 lines) Patch
M trunk/src/ash/shell/content_client/shell_browser_main_parts.cc View 3 chunks +8 lines, -1 line 0 comments Download
M trunk/src/ash/test/ash_test_helper.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M trunk/src/build/common.gypi View 4 chunks +12 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/about_flags.cc View 3 chunks +6 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/browser_process.h View 2 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/browser_process_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/browser_process_impl.cc View 5 chunks +10 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/chrome_content_browser_client.cc View 3 chunks +6 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/notifications/notifications_api.cc View 3 chunks +27 lines, -24 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/notifications/notifications_apitest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 2 chunks +74 lines, -44 lines 0 comments Download
M trunk/src/chrome/browser/extensions/notifications_apitest.cc View 5 chunks +52 lines, -28 lines 0 comments Download
M trunk/src/chrome/browser/notifications/desktop_notification_service.cc View 9 chunks +20 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/notifications/message_center_notifications_browsertest.cc View 3 chunks +7 lines, -31 lines 0 comments Download
M trunk/src/chrome/browser/notifications/notification.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/notifications/notification_browsertest.cc View 22 chunks +110 lines, -99 lines 0 comments Download
M trunk/src/chrome/browser/notifications/notification_ui_manager.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/notifications/notification_ui_manager_mac.mm View 2 chunks +6 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/notifications/sync_notifier/synced_notification.cc View 5 chunks +16 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/task_manager/task_manager_notification_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 2 chunks +12 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/base/testing_browser_process.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/base/testing_browser_process.cc View 3 chunks +6 lines, -1 line 0 comments Download
M trunk/src/chrome/test/base/view_event_test_base.cc View 3 chunks +8 lines, -1 line 0 comments Download
D trunk/src/ui/message_center/dummy_message_center.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M trunk/src/ui/message_center/message_center.gyp View 4 chunks +1 line, -23 lines 0 comments Download
M trunk/src/ui/message_center/message_center_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/ui/message_center/message_center_util.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years, 7 months ago (2013-05-12 23:07:37 UTC) #1
Nico
7 years, 7 months ago (2013-05-12 23:08:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r199639.

Powered by Google App Engine
This is Rietveld 408576698