Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: trunk/src/chrome/browser/task_manager/task_manager_notification_browsertest.cc

Issue 14631021: Revert 199625 "Remove ENABLE_MESSAGE_CENTER" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_manager/task_manager.h" 5 #include "chrome/browser/task_manager/task_manager.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/extensions/extension_browsertest.h" 9 #include "chrome/browser/extensions/extension_browsertest.h"
10 #include "chrome/browser/notifications/desktop_notification_service.h" 10 #include "chrome/browser/notifications/desktop_notification_service.h"
11 #include "chrome/browser/notifications/notification.h" 11 #include "chrome/browser/notifications/notification.h"
12 #include "chrome/browser/notifications/notification_test_util.h" 12 #include "chrome/browser/notifications/notification_test_util.h"
13 #include "chrome/browser/notifications/notification_ui_manager.h" 13 #include "chrome/browser/notifications/notification_ui_manager.h"
14 #include "chrome/browser/task_manager/task_manager_browsertest_util.h" 14 #include "chrome/browser/task_manager/task_manager_browsertest_util.h"
15 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
16 #include "chrome/browser/ui/browser_dialogs.h" 16 #include "chrome/browser/ui/browser_dialogs.h"
17 #include "chrome/browser/ui/browser_window.h" 17 #include "chrome/browser/ui/browser_window.h"
18 #include "chrome/test/base/in_process_browser_test.h" 18 #include "chrome/test/base/in_process_browser_test.h"
19 #include "chrome/test/base/ui_test_utils.h" 19 #include "chrome/test/base/ui_test_utils.h"
20 #include "content/public/common/content_switches.h" 20 #include "content/public/common/content_switches.h"
21 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
22 #include "ui/message_center/message_center_util.h" 22
23 #if !defined(ENABLE_MESSAGE_CENTER)
24 // These tests do not apply with Message Center platforms
25 // where notifications do not instantiate a new renderer.
23 26
24 class TaskManagerNotificationBrowserTest : public ExtensionBrowserTest { 27 class TaskManagerNotificationBrowserTest : public ExtensionBrowserTest {
25 public: 28 public:
26 TaskManagerModel* model() const { 29 TaskManagerModel* model() const {
27 return TaskManager::GetInstance()->model(); 30 return TaskManager::GetInstance()->model();
28 } 31 }
29 protected: 32 protected:
30 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { 33 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
31 ExtensionBrowserTest::SetUpCommandLine(command_line); 34 ExtensionBrowserTest::SetUpCommandLine(command_line);
32 35
33 // Do not prelaunch the GPU process for these tests because it will show 36 // Do not prelaunch the GPU process for these tests because it will show
34 // up in task manager but whether it appears before or after the new tab 37 // up in task manager but whether it appears before or after the new tab
35 // renderer process is not well defined. 38 // renderer process is not well defined.
36 command_line->AppendSwitch(switches::kDisableGpuProcessPrelaunch); 39 command_line->AppendSwitch(switches::kDisableGpuProcessPrelaunch);
37 } 40 }
38 }; 41 };
39 42
40 // TODO(linux_aura) http://crbug.com/163931 43 // TODO(linux_aura) http://crbug.com/163931
41 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) 44 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA)
42 #define MAYBE_NoticeNotificationChanges DISABLED_NoticeNotificationChanges 45 #define MAYBE_NoticeNotificationChanges DISABLED_NoticeNotificationChanges
43 #else 46 #else
44 #define MAYBE_NoticeNotificationChanges NoticeNotificationChanges 47 #define MAYBE_NoticeNotificationChanges NoticeNotificationChanges
45 #endif 48 #endif
46 IN_PROC_BROWSER_TEST_F(TaskManagerNotificationBrowserTest, 49 IN_PROC_BROWSER_TEST_F(TaskManagerNotificationBrowserTest,
47 MAYBE_NoticeNotificationChanges) { 50 MAYBE_NoticeNotificationChanges) {
48 // These tests do not apply with Message Center platforms
49 // where notifications do not instantiate a new renderer.
50 if (message_center::IsRichNotificationEnabled())
51 return;
52
53 EXPECT_EQ(0, model()->ResourceCount()); 51 EXPECT_EQ(0, model()->ResourceCount());
54 52
55 // Show the task manager. 53 // Show the task manager.
56 chrome::ShowTaskManager(browser(), false); 54 chrome::ShowTaskManager(browser(), false);
57 // Expect to see the browser and the New Tab Page renderer. 55 // Expect to see the browser and the New Tab Page renderer.
58 TaskManagerBrowserTestUtil::WaitForWebResourceChange(1); 56 TaskManagerBrowserTestUtil::WaitForWebResourceChange(1);
59 57
60 // Show a notification. 58 // Show a notification.
61 NotificationUIManager* notifications = 59 NotificationUIManager* notifications =
62 g_browser_process->notification_ui_manager(); 60 g_browser_process->notification_ui_manager();
(...skipping 11 matching lines...) Expand all
74 72
75 notifications->Add(n1, browser()->profile()); 73 notifications->Add(n1, browser()->profile());
76 TaskManagerBrowserTestUtil::WaitForWebResourceChange(2); 74 TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
77 notifications->Add(n2, browser()->profile()); 75 notifications->Add(n2, browser()->profile());
78 TaskManagerBrowserTestUtil::WaitForWebResourceChange(3); 76 TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
79 notifications->CancelById(n1.notification_id()); 77 notifications->CancelById(n1.notification_id());
80 TaskManagerBrowserTestUtil::WaitForWebResourceChange(2); 78 TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
81 notifications->CancelById(n2.notification_id()); 79 notifications->CancelById(n2.notification_id());
82 TaskManagerBrowserTestUtil::WaitForWebResourceChange(1); 80 TaskManagerBrowserTestUtil::WaitForWebResourceChange(1);
83 } 81 }
82
83 #endif // !ENABLE_MESSAGE_CENTER
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698