Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: Source/modules/webaudio/AudioDestinationNode.h

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioDestinationNode.h
diff --git a/Source/modules/webaudio/AudioDestinationNode.h b/Source/modules/webaudio/AudioDestinationNode.h
index e1b81e78659ada6bfa736e998c6d0a3c00ee79e0..d1f28576e7fbe75fdf80c7ace5bbb089c8e90c14 100644
--- a/Source/modules/webaudio/AudioDestinationNode.h
+++ b/Source/modules/webaudio/AudioDestinationNode.h
@@ -67,27 +67,27 @@ protected:
class LocalAudioInputProvider : public AudioSourceProvider {
public:
LocalAudioInputProvider()
- : m_sourceBus(2, AudioNode::ProcessingSizeInFrames) // FIXME: handle non-stereo local input.
+ : m_sourceBus(new AudioBus(2, AudioNode::ProcessingSizeInFrames)) // FIXME: handle non-stereo local input.
Chris Rogers 2013/05/02 17:48:46 adoptRef()
{
}
void set(AudioBus* bus)
{
if (bus)
- m_sourceBus.copyFrom(*bus);
+ m_sourceBus->copyFrom(*bus);
}
// AudioSourceProvider.
virtual void provideInput(AudioBus* destinationBus, size_t numberOfFrames)
{
- bool isGood = destinationBus && destinationBus->length() == numberOfFrames && m_sourceBus.length() == numberOfFrames;
+ bool isGood = destinationBus && destinationBus->length() == numberOfFrames && m_sourceBus->length() == numberOfFrames;
ASSERT(isGood);
if (isGood)
- destinationBus->copyFrom(m_sourceBus);
+ destinationBus->copyFrom(*m_sourceBus);
}
private:
- AudioBus m_sourceBus;
+ RefPtr<AudioBus> m_sourceBus;
};
virtual double tailTime() const OVERRIDE { return 0; }

Powered by Google App Engine
This is Rietveld 408576698