Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: Source/modules/webaudio/AudioDestinationNode.h

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 virtual void startRendering() = 0; 60 virtual void startRendering() = 0;
61 61
62 AudioSourceProvider* localAudioInputProvider() { return &m_localAudioInputPr ovider; } 62 AudioSourceProvider* localAudioInputProvider() { return &m_localAudioInputPr ovider; }
63 63
64 protected: 64 protected:
65 // LocalAudioInputProvider allows us to expose an AudioSourceProvider for lo cal/live audio input. 65 // LocalAudioInputProvider allows us to expose an AudioSourceProvider for lo cal/live audio input.
66 // If there is local/live audio input, we call set() with the audio input da ta every render quantum. 66 // If there is local/live audio input, we call set() with the audio input da ta every render quantum.
67 class LocalAudioInputProvider : public AudioSourceProvider { 67 class LocalAudioInputProvider : public AudioSourceProvider {
68 public: 68 public:
69 LocalAudioInputProvider() 69 LocalAudioInputProvider()
70 : m_sourceBus(2, AudioNode::ProcessingSizeInFrames) // FIXME: handle non-stereo local input. 70 : m_sourceBus(new AudioBus(2, AudioNode::ProcessingSizeInFrames)) // FIXME: handle non-stereo local input.
Chris Rogers 2013/05/02 17:48:46 adoptRef()
71 { 71 {
72 } 72 }
73 73
74 void set(AudioBus* bus) 74 void set(AudioBus* bus)
75 { 75 {
76 if (bus) 76 if (bus)
77 m_sourceBus.copyFrom(*bus); 77 m_sourceBus->copyFrom(*bus);
78 } 78 }
79 79
80 // AudioSourceProvider. 80 // AudioSourceProvider.
81 virtual void provideInput(AudioBus* destinationBus, size_t numberOfFrame s) 81 virtual void provideInput(AudioBus* destinationBus, size_t numberOfFrame s)
82 { 82 {
83 bool isGood = destinationBus && destinationBus->length() == numberOf Frames && m_sourceBus.length() == numberOfFrames; 83 bool isGood = destinationBus && destinationBus->length() == numberOf Frames && m_sourceBus->length() == numberOfFrames;
84 ASSERT(isGood); 84 ASSERT(isGood);
85 if (isGood) 85 if (isGood)
86 destinationBus->copyFrom(m_sourceBus); 86 destinationBus->copyFrom(*m_sourceBus);
87 } 87 }
88 88
89 private: 89 private:
90 AudioBus m_sourceBus; 90 RefPtr<AudioBus> m_sourceBus;
91 }; 91 };
92 92
93 virtual double tailTime() const OVERRIDE { return 0; } 93 virtual double tailTime() const OVERRIDE { return 0; }
94 virtual double latencyTime() const OVERRIDE { return 0; } 94 virtual double latencyTime() const OVERRIDE { return 0; }
95 95
96 // Counts the number of sample-frames processed by the destination. 96 // Counts the number of sample-frames processed by the destination.
97 size_t m_currentSampleFrame; 97 size_t m_currentSampleFrame;
98 98
99 LocalAudioInputProvider m_localAudioInputProvider; 99 LocalAudioInputProvider m_localAudioInputProvider;
100 }; 100 };
101 101
102 } // namespace WebCore 102 } // namespace WebCore
103 103
104 #endif // AudioDestinationNode_h 104 #endif // AudioDestinationNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698