Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1462783002: Revert SkBlitMask_opts.h back to hand-coded NEON. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert SkBlitMask_opts.h back to hand-coded NEON. SkPx has triggered a bunch of small (2-9%) regressions on NEON devices. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/9b341146d92b53d8f1b357924eab097a2e1eabca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -40 lines) Patch
M src/opts/SkBlitMask_opts.h View 1 chunk +173 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462783002/1
5 years, 1 month ago (2015-11-19 02:45:58 UTC) #2
mtklein
lgtm
5 years, 1 month ago (2015-11-19 02:56:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462783002/1
5 years, 1 month ago (2015-11-19 02:57:01 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:59:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9b341146d92b53d8f1b357924eab097a2e1eabca

Powered by Google App Engine
This is Rietveld 408576698