Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1462693004:
Enable building of ppapi_nacl tests for arm/glibc (Closed)
DescriptionEnable building of ppapi_nacl tests for arm/glibc
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=505885
Committed: https://crrev.com/4df2d47c986e15641bcea90198558ec88ca7c2dc
Cr-Commit-Position: refs/heads/master@{#361029}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #
Dependent Patchsets: Messages
Total messages: 36 (17 generated)
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462693004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462693004/60001
Description was changed from ========== Enable building of ppapi_nacl tests for arm/glibc BUG= ========== to ========== Enable building of ppapi_nacl tests for arm/glibc ==========
sbc@chromium.org changed reviewers: + mcgrathr@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enable building of ppapi_nacl tests for arm/glibc ========== to ========== Enable building of ppapi_nacl tests for arm/glibc BUG=505885 ==========
On 2015/11/19 10:35:16, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. PTAL. Note that this change doesn't actually enable the running the glibc tests, only the building of the nmf and nexes. The enabling of them is in a separate CL (which currently is not green): https://codereview.chromium.org/1403793004/
+bbudge for ppapi +maruel for browser_tests.isolate +dpranke for build/common.gypi
lgtm
maruel@chromium.org changed reviewers: + maruel@chromium.org
rs lgtm
Description was changed from ========== Enable building of ppapi_nacl tests for arm/glibc BUG=505885 ========== to ========== Enable building of ppapi_nacl tests for arm/glibc CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile BUG=505885 ==========
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462693004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462693004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
The CQ bit was checked by sbc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, maruel@chromium.org, mcgrathr@chromium.org Link to the patchset: https://codereview.chromium.org/1462693004/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462693004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462693004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462693004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462693004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sbc@chromium.org changed reviewers: + raymes@chromium.org
+raymes for ppapi/OWNERS (bbudge seems to be OOO today)
rubberstamp lgtm for ppapi
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462693004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462693004/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/4df2d47c986e15641bcea90198558ec88ca7c2dc Cr-Commit-Position: refs/heads/master@{#361029} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
