Enable NaCl glibc tests on ARM

Enable NaCl glibc tests on ARM

We now have a working ARM glibc toolchain so invert
the check and disable glibc tests only on MIPS.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=505885
Committed: https://crrev.com/ff414abc8745cae4752eb0305f78728f3aeca87e
Cr-Commit-Position: refs/heads/master@{#361514}

[Sam Clegg, 2015-11-18 01:05:39]

sbc@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Sam Clegg, 2015-11-18 01:05:40]

Trybot should be running tests now, so I hope that a green try run here will
confirm that arm/linux is working the browser.

[Sam Clegg, 2015-11-19 18:51:22]

Looks like we are getting the following error for the glibc arm PPAPI tests:

NaClMain: error while loading shared libraries: libppapi_cpp.so: failed to map
segment from shared object

[Roland McGrath, 2015-11-23 21:58:59]

https://codereview.chromium.org/1403793004/diff/160001/DEPS
File DEPS (right):

https://codereview.chromium.org/1403793004/diff/160001/DEPS#newcode90
DEPS:90: 'nacl_revision': 'cdb63dfab228f03f7f69b22594d807406710d03b',
The DEPS roll does not belong in this CL.

[Sam Clegg, 2015-11-23 22:55:34]

On 2015/11/23 21:58:59, Roland McGrath wrote:
> https://codereview.chromium.org/1403793004/diff/160001/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/1403793004/diff/160001/DEPS#newcode90
> DEPS:90: 'nacl_revision': 'cdb63dfab228f03f7f69b22594d807406710d03b',
> The DEPS roll does not belong in this CL.

Sorry, I know,  I just wanted to run the tests along with you fix.  Is there
some other way?

[Sam Clegg, 2015-11-23 22:56:46]

On 2015/11/23 22:55:34, Sam Clegg wrote:
> On 2015/11/23 21:58:59, Roland McGrath wrote:
> > https://codereview.chromium.org/1403793004/diff/160001/DEPS
> > File DEPS (right):
> > 
> > https://codereview.chromium.org/1403793004/diff/160001/DEPS#newcode90
> > DEPS:90: 'nacl_revision': 'cdb63dfab228f03f7f69b22594d807406710d03b',
> > The DEPS roll does not belong in this CL.
> 
> Sorry, I know,  I just wanted to run the tests along with you fix.  Is there
> some other way?

Looks like all the test but one passed!

NaClBrowserTestGLibcVcacheExtension.ValidationCacheOfMainNexe 
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...

[Roland McGrath, 2015-11-23 22:56:56]

On 2015/11/23 22:55:34, Sam Clegg wrote:
> On 2015/11/23 21:58:59, Roland McGrath wrote:
> > https://codereview.chromium.org/1403793004/diff/160001/DEPS
> > File DEPS (right):
> > 
> > https://codereview.chromium.org/1403793004/diff/160001/DEPS#newcode90
> > DEPS:90: 'nacl_revision': 'cdb63dfab228f03f7f69b22594d807406710d03b',
> > The DEPS roll does not belong in this CL.
> 
> Sorry, I know,  I just wanted to run the tests along with you fix.  Is there
> some other way?

No, that's the way.  You should just upload versions both with and without the
testing-only changes and make clear in your review messages which patch sets are
for trybots and which are for potential commit.

[Roland McGrath, 2015-11-23 22:59:44]

On 2015/11/23 22:56:46, Sam Clegg wrote:
> NaClBrowserTestGLibcVcacheExtension.ValidationCacheOfMainNexe 
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...

That looks like an authentic need to adjust the test. 
chromium/src/chrome/test/nacl/nacl_browsertest_uma.cc:199 encodes an exact
expected list of files loaded from the manifest file.  For nacl_arm_glibc, there
will also be elf_loader in there, so its expectation needs to be adjusted.

[Sam Clegg, 2015-11-23 23:04:47]

Description was changed from

==========
Enable NaCl glibc tests on ARM

We now have a working ARM glibc toolchain so invert
the check and disable glibc tests only on MIPS.

BUG=505885
==========

to

==========
Enable NaCl glibc tests on ARM

We now have a working ARM glibc toolchain so invert
the check and disable glibc tests only on MIPS.

DO NOT SUBMIT (contains test-only DEPS roll)

BUG=505885
==========

[Sam Clegg, 2015-11-23 23:06:01]

On 2015/11/23 22:59:44, Roland McGrath wrote:
> On 2015/11/23 22:56:46, Sam Clegg wrote:
> > NaClBrowserTestGLibcVcacheExtension.ValidationCacheOfMainNexe 
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...
> 
> That looks like an authentic need to adjust the test. 
> chromium/src/chrome/test/nacl/nacl_browsertest_uma.cc:199 encodes an exact
> expected list of files loaded from the manifest file.  For nacl_arm_glibc,
there
> will also be elf_loader in there, so its expectation needs to be adjusted.

Is there a DEPS roll on the way that contains your latest arm/glibc?  if not
can/should we trigger one?  I'd love to land this change this week.

[Roland McGrath, 2015-11-23 23:18:56]

On 2015/11/23 23:06:01, Sam Clegg wrote:
> On 2015/11/23 22:59:44, Roland McGrath wrote:
> > On 2015/11/23 22:56:46, Sam Clegg wrote:
> > > NaClBrowserTestGLibcVcacheExtension.ValidationCacheOfMainNexe 
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...
> > 
> > That looks like an authentic need to adjust the test. 
> > chromium/src/chrome/test/nacl/nacl_browsertest_uma.cc:199 encodes an exact
> > expected list of files loaded from the manifest file.  For nacl_arm_glibc,
> there
> > will also be elf_loader in there, so its expectation needs to be adjusted.
> 
> Is there a DEPS roll on the way that contains your latest arm/glibc?  if not
> can/should we trigger one?  I'd love to land this change this week.

There is https://codereview.chromium.org/1467853002/ but I decided to avoid
landing any more rolls until
https://code.google.com/p/chromium/issues/detail?id=560295 is resolved, to avoid
confusion with potential reverts.  Fixing that is waiting for the pnacl
toolchain builders and a toolchain roll before I can do another nacl->chromium
roll.  I hope to get that all finished on Tuesday.

[Sam Clegg, 2015-11-24 21:39:20]

sbc@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Sam Clegg, 2015-11-24 21:39:20]

+bradnelson for OWNERS

[Sam Clegg, 2015-11-24 21:39:43]

Description was changed from

==========
Enable NaCl glibc tests on ARM

We now have a working ARM glibc toolchain so invert
the check and disable glibc tests only on MIPS.

DO NOT SUBMIT (contains test-only DEPS roll)

BUG=505885
==========

to

==========
Enable NaCl glibc tests on ARM

We now have a working ARM glibc toolchain so invert
the check and disable glibc tests only on MIPS.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=505885
==========

[Sam Clegg, 2015-11-24 21:39:47]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 21:41:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403793004/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403793004/220001

[bradnelson, 2015-11-24 23:11:14]

lgtm

[commit-bot: I haz the power, 2015-11-24 23:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 23:32:29]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2015-11-24 23:34:05]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-11-24 23:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403793004/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403793004/220001

[commit-bot: I haz the power, 2015-11-25 01:14:00]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-11-25 01:16:03]

Patchset 12 (id:??) landed as
https://crrev.com/ff414abc8745cae4752eb0305f78728f3aeca87e
Cr-Commit-Position: refs/heads/master@{#361514}