Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 1462693002: Report error for ignored priority file. Ignore subscription for ignored files. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 93c929c7daa1022a169cc4b5494d146a5bc885e4..2b58ebfb40d0523e6da6ee00932821a843b750ac 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -977,8 +977,11 @@ class AnalysisServer {
Set<String> todoFiles =
oldFiles != null ? newFiles.difference(oldFiles) : newFiles;
for (String file in todoFiles) {
- ContextSourcePair contextSource = getContextSourcePair(file);
+ if (contextManager.isIgnored(file)) {
+ continue;
Brian Wilkerson 2015/11/19 00:17:08 Do we need to remember the subscriptions so that i
scheglov 2015/11/19 01:30:16 Actually yes, we need. But we don't do it now. So,
+ }
// prepare context
+ ContextSourcePair contextSource = getContextSourcePair(file);
AnalysisContext context = contextSource.context;
if (context == null) {
continue;
@@ -1066,6 +1069,11 @@ class AnalysisServer {
List<String> unanalyzed = new List<String>();
Source firstSource = null;
files.forEach((String file) {
+ if (contextManager.isIgnored(file)) {
+ unanalyzed.add(file);
+ return;
+ }
+ // Prepare the context/source pair.
ContextSourcePair contextSource = getContextSourcePair(file);
AnalysisContext preferredContext = contextSource.context;
Source source = contextSource.source;
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698