Report error for ignored priority file. Ignore subscription for ignored files.

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core' hide Resource;
 import 'dart:math' show max;
@@ skipping 959 matching lines @@
    * Implementation for `analysis.setSubscriptions`.
    */
   void setAnalysisSubscriptions(
       Map<AnalysisService, Set<String>> subscriptions) {
     // send notifications for already analyzed sources
     subscriptions.forEach((service, Set<String> newFiles) {
       Set<String> oldFiles = analysisServices[service];
       Set<String> todoFiles =
           oldFiles != null ? newFiles.difference(oldFiles) : newFiles;
       for (String file in todoFiles) {
+        if (contextManager.isIgnored(file)) {
+          continue;

[Brian Wilkerson, 2015/11/19 00:17:08]

Do we need to remember the subscriptions so that if we stop ignoring the file
then the subscriptions will take effect? Seems like that would be consistent
with the rest of the API, but it might be overkill.

[scheglov, 2015/11/19 01:30:16]

Actually yes, we need.
But we don't do it now.
So, it is a bug, but it's not a regression.

I've opened a new issue.
https://github.com/dart-lang/sdk/issues/24979

+        }
+        // prepare context
         ContextSourcePair contextSource = getContextSourcePair(file);
-        // prepare context
         AnalysisContext context = contextSource.context;
         if (context == null) {
           continue;
         }
         Source source = contextSource.source;
         // Ensure that if the AST is flushed / not ready, it will be
         // computed eventually.
         if (AnalysisEngine.isDartFileName(file)) {
           (context as InternalAnalysisContext).ensureResolvedDartUnits(source);
         }
@@ skipping 67 matching lines @@
   void setPriorityFiles(String requestId, List<String> files) {
     // Note: when a file is a priority file, that information needs to be
     // propagated to all contexts that analyze the file, so that all contexts
     // will be able to do incremental resolution of the file.  See
     // dartbug.com/22209.
     Map<AnalysisContext, List<Source>> sourceMap =
         new HashMap<AnalysisContext, List<Source>>();
     List<String> unanalyzed = new List<String>();
     Source firstSource = null;
     files.forEach((String file) {
+      if (contextManager.isIgnored(file)) {
+        unanalyzed.add(file);
+        return;
+      }
+      // Prepare the context/source pair.
       ContextSourcePair contextSource = getContextSourcePair(file);
       AnalysisContext preferredContext = contextSource.context;
       Source source = contextSource.source;
       // Try to make the file analyzable.
       // If it is not in any context yet, add it to the first one which
       // could use it, e.g. imports its package, even if not the library.
       if (preferredContext == null) {
         Resource resource = resourceProvider.getResource(file);
         if (resource is File && resource.exists) {
           for (AnalysisContext context in folderMap.values) {
@@ skipping 587 matching lines @@
   /**
    * The [PerformanceTag] for time spent in server request handlers.
    */
   static PerformanceTag serverRequests = new PerformanceTag('serverRequests');
 
   /**
    * The [PerformanceTag] for time spent in split store microtasks.
    */
   static PerformanceTag splitStore = new PerformanceTag('splitStore');
 }