Report error for ignored priority file. Ignore subscription for ignored files.

Report error for ignored priority file. Ignore subscription for ignored files.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a689bf41805c251b5bae646e0eb82f832d1e309f

[Brian Wilkerson, 2015-11-19 00:17:07]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2015-11-19 00:17:08]

LGTM unless my question requires changes

https://codereview.chromium.org/1462693002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1462693002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:981: continue;
Do we need to remember the subscriptions so that if we stop ignoring the file
then the subscriptions will take effect? Seems like that would be consistent
with the rest of the API, but it might be overkill.

[scheglov, 2015-11-19 01:30:16]

https://codereview.chromium.org/1462693002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1462693002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:981: continue;
On 2015/11/19 00:17:08, Brian Wilkerson wrote:
> Do we need to remember the subscriptions so that if we stop ignoring the file
> then the subscriptions will take effect? Seems like that would be consistent
> with the rest of the API, but it might be overkill.

Actually yes, we need.
But we don't do it now.
So, it is a bug, but it's not a regression.

I've opened a new issue.
https://github.com/dart-lang/sdk/issues/24979

[scheglov, 2015-11-19 01:32:04]

Committed patchset #1 (id:1) manually as
a689bf41805c251b5bae646e0eb82f832d1e309f (presubmit successful).