Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1462603003: Revert of Disable failing tests on Mac 10.10 Release (ATI) (Closed)

Created:
5 years, 1 month ago by miu
Modified:
5 years, 1 month ago
Reviewers:
hubbe, hcarmona
CC:
chromium-reviews, extensions-reviews_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable failing tests on Mac 10.10 Release (ATI) (patchset #1 id:1 of https://codereview.chromium.org/1456863003/ ) Reason for revert: Per research and discussion on http://crbug.com/557929, we are pretty sure the bot is to blame and NOT the CLs or these tests. Original issue's description: > Disable failing tests on Mac 10.10 Release (ATI) > > Failing tests on Mac OS: > CastStreamingApiTestWithPixelOutput.EndToEnd > TabCaptureApiPixelTest.EndToEndThroughWebRTC > TabCaptureApiPixelTest.EndToEndWithoutRemoting > > BUG=557929 > TBR=hubbe@chromium.org, miu@chromium.org > > Committed: https://crrev.com/872e59f9875efaad8b73b44cf2707c0a57d52244 > Cr-Commit-Position: refs/heads/master@{#360460} TBR=hubbe@chromium.org,hcarmona@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557929 Committed: https://crrev.com/e13dcf9353b40f8f0d10d3aecbfdea145928fb10 Cr-Commit-Position: refs/heads/master@{#360634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
miu
Created Revert of Disable failing tests on Mac 10.10 Release (ATI)
5 years, 1 month ago (2015-11-19 02:51:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462603003/1
5 years, 1 month ago (2015-11-19 18:49:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 18:50:48 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 18:51:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e13dcf9353b40f8f0d10d3aecbfdea145928fb10
Cr-Commit-Position: refs/heads/master@{#360634}

Powered by Google App Engine
This is Rietveld 408576698