Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 14626005: Upgrade elements that are created before a custom element definition is registered (Closed)

Created:
7 years, 7 months ago by dominicc (has gone to gerrit)
Modified:
7 years, 7 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Upgrade elements that are created before a custom element definition is registered This implements the essential aspects of the Custom Elements "element upgrade algorithm" <https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/custom/index.html#dfn-element-upgrade>; BUG=233775 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149688

Patch Set 1 #

Patch Set 2 : Moar better #

Patch Set 3 : Moar^2 better #

Total comments: 1

Patch Set 4 : Feedback+test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -55 lines) Patch
A LayoutTests/fast/dom/custom/element-upgrade.html View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/element-upgrade-expected.txt View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/custom/unresolved-pseudoclass.html View 1 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/unresolved-pseudoclass-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/v8/CustomElementHelpers.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M Source/bindings/v8/CustomElementHelpers.cpp View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/CustomElementDefinition.h View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.h View 1 2 3 4 chunks +13 lines, -13 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.cpp View 1 6 chunks +15 lines, -8 lines 0 comments Download
A + Source/core/dom/CustomElementUpgradeCandidateMap.h View 1 2 3 1 chunk +30 lines, -21 lines 0 comments Download
A Source/core/dom/CustomElementUpgradeCandidateMap.cpp View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/scripts/make_names.pl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
dominicc (has gone to gerrit)
This is a work-in-progress but if you have cycles for early advice it would be ...
7 years, 7 months ago (2013-05-03 08:55:47 UTC) #1
dglazkov
This looks good enough to land. Don't forget to remove (WIP) in the title of ...
7 years, 7 months ago (2013-05-03 16:09:39 UTC) #2
dominicc (has gone to gerrit)
I added a test; PTAL.
7 years, 7 months ago (2013-05-03 17:26:22 UTC) #3
dglazkov
LGTM.
7 years, 7 months ago (2013-05-03 19:17:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/14626005/13001
7 years, 7 months ago (2013-05-03 20:49:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=3848
7 years, 7 months ago (2013-05-03 23:09:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/14626005/13001
7 years, 7 months ago (2013-05-04 00:56:43 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-05-04 01:34:01 UTC) #8
dominicc (has gone to gerrit)
I will try the CQ one more time; if that doesn't work I will commit ...
7 years, 7 months ago (2013-05-04 02:02:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/14626005/13001
7 years, 7 months ago (2013-05-04 02:02:41 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6642
7 years, 7 months ago (2013-05-04 02:53:22 UTC) #11
dominicc (has gone to gerrit)
7 years, 7 months ago (2013-05-04 10:44:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 manually as r149688 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698