downloads: Make GetCrDownloadPath a static method on DownloadTargetDeterminer.

downloads: Make GetCrDownloadPath a static method on DownloadTargetDeterminer.

BUG=104549
R=asanka@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200231

[tfarina, 2013-05-14 02:44:44]

indentation was done using clang-format.

Please, could you review this to me?

Thanks!

[asanka, 2013-05-14 14:48:07]

LGTM. Thanks!

[Randy Smith (Not in Mondays), 2013-05-14 15:20:04]

On 2013/05/14 14:48:07, asanka wrote:
> LGTM. Thanks!

In general, I think Asanka's a fine reviewer for this sort of change.  And I'm
(at least in theory) off of downloads at this point.  So I'm going to take
myself off of this CL and the other one you posted on formatting changes. 
Thanks for doing this!

[commit-bot: I haz the power, 2013-05-15 04:17:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/14625016/1

[commit-bot: I haz the power, 2013-05-15 04:18:01]

Failed to apply patch for chrome/browser/download/download_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/download/download_browsertest.cc
  Hunk #3 FAILED at 1720.
  Hunk #4 succeeded at 1770 (offset -1 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/download/download_browsertest.cc.rej

Patch:       chrome/browser/download/download_browsertest.cc
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc
b/chrome/browser/download/download_browsertest.cc
index
b8e57fc8483b21c6515c359fd20b5ae278624bc6..3e5cfe782fcf6b3d2c2bd2141e8b092ea0ccbd29
100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -30,8 +30,8 @@
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/download/download_shelf.h"
+#include "chrome/browser/download/download_target_determiner.h"
 #include "chrome/browser/download/download_test_file_activity_observer.h"
-#include "chrome/browser/download/download_util.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
@@ -1685,7 +1685,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadHistoryCheck)
{
   // slow download job.
   history::DownloadRow& row(downloads_in_database->at(0));
   EXPECT_EQ(DestinationFile(browser(), file), row.target_path);
-  EXPECT_EQ(download_util::GetCrDownloadPath(DestinationFile(browser(), file)),
+  EXPECT_EQ(DownloadTargetDeterminer::GetCrDownloadPath(
+                DestinationFile(browser(), file)),
             row.current_path);
   ASSERT_EQ(2u, row.url_chain.size());
   EXPECT_EQ(redirect_url.spec(), row.url_chain[0].spec());
@@ -1719,7 +1720,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadHistoryCheck)
{
   // slow download job.
   history::DownloadRow& row1(downloads_in_database->at(0));
   EXPECT_EQ(DestinationFile(browser(), file), row1.target_path);
-  EXPECT_EQ(download_util::GetCrDownloadPath(DestinationFile(browser(), file)),
+  EXPECT_EQ(DownloadTargetDeterminer::GetCrDownloadPath(
+                DestinationFile(browser(), file)),
             row1.current_path);
   ASSERT_EQ(2u, row1.url_chain.size());
   EXPECT_EQ(redirect_url.spec(), row1.url_chain[0].spec());
@@ -1770,7 +1772,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest,
DownloadHistoryDangerCheck) {
   // dangerous file.
   history::DownloadRow& row(downloads_in_database->at(0));
   EXPECT_EQ(DestinationFile(browser(), file), row.target_path);
-  EXPECT_NE(download_util::GetCrDownloadPath(DestinationFile(browser(), file)),
+  EXPECT_NE(DownloadTargetDeterminer::GetCrDownloadPath(
+                DestinationFile(browser(), file)),
             row.current_path);
   EXPECT_EQ(content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE, row.danger_type);
   EXPECT_LE(start, row.start_time);

[commit-bot: I haz the power, 2013-05-15 05:04:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/14625016/11001

[commit-bot: I haz the power, 2013-05-15 10:11:04]

Change committed as 200231